Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: bucket pagination#658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

mbenabda
Copy link
Contributor

@mbenabdambenabda commentedMay 24, 2024•
edited
Loading

Proposed Changes

Simliar to#616 for buckets:
Addbuckets_api.find_buckets_iter to make usage of buckets pagination simpler

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages areconventional
  • SignCLA (if not already signed)

@mbenabdambenabdaforce-pushed thepr/add_paging_to_buckets_api branch 3 times, most recently from8e90900 tof3f0914CompareMay 24, 2024 13:10
@mbenabdambenabdaforce-pushed thepr/add_paging_to_buckets_api branch fromf3f0914 to7bf9322CompareMay 24, 2024 21:15
@mbenabdambenabda marked this pull request as ready for reviewMay 25, 2024 16:51
Copy link
Contributor

@bednarbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@mbenabda, thank you very much for your PR. Before we can proceed with merging, there are a few requirements that need to be met:

mbenabda reacted with thumbs up emoji
Co-authored-by: Jakub Bednář <jakub.bednar@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commentedMay 27, 2024•
edited
Loading

⚠️ Please install the'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is95.65217% with2 lines in your changes missing coverage. Please review.

Project coverage is 90.43%. Comparing base(73849e7) to head(15a7880).
Report is 9 commits behind head on master.

FilesPatch %Lines
influxdb_client/client/_pages.py95.12%2 Missing⚠️

❗ Your organization needs to install theCodecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@##           master     #658      +/-   ##==========================================+ Coverage   90.40%   90.43%   +0.02%==========================================  Files          39       40       +1       Lines        3513     3524      +11     ==========================================+ Hits         3176     3187      +11  Misses        337      337

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Copy link
Contributor

@bednarbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks again for your PR 👍

LGTM 🚀

mbenabda reacted with thumbs up emoji
@bednarbednar added this to the1.44.0 milestoneMay 28, 2024
@bednarbednar merged commit6798be4 intoinfluxdata:masterMay 28, 2024
15 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bednarbednarbednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.44.0
Development

Successfully merging this pull request may close these issues.

3 participants
@mbenabda@codecov-commenter@bednar
[8]ページ先頭
©2009-2025 Movatter.jp