This PR changes the behavior ofget_date_helper to preferdatetime.datetime.fromisoformat overdateutil.parser in Python 3.11 or higher.
According tohttps://github.com/closeio/ciso8601/blob/b17984f5b4c6db0ef596b4d31456c8a39ae278ee/why_ciso8601.md,Since Python 3.11+, the performance of cPython's datetime.fromisoformat is now very good. I did some quick testing and it seems to be on a par withciso8601:
On Python 3.10 I've got ~37,5s and ~3,5s without and withciso8601 installed, respectively. On Python 3.11 I've got ~2,5s and ~2,6s without and withciso8601 installed, respectively.

Becauseciso is no dependency, but an extra, not all users (including me) installed it. With this PR these users will get a better out-of-the-box performance for Python 3.11+ users.

Checklist

CHANGELOG.md updated
Rebased/mergeable
A test has been added if appropriate
pytest tests completes successfully
Commit messages areconventional
SignCLA (if not already signed)

Copy link

codecov-commenter commentedMay 18, 2024•
edited
Loading

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is75.00000% with1 line in your changes missing coverage. Please review.

Project coverage is 90.40%. Comparing base(d2393e0) to head(b97b611).
Report is 9 commits behind head on master.

Files	Patch %	Lines
influxdb_client/client/util/date_utils.py	75.00%	1 Missing⚠️

❗ Your organization needs to install theCodecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@##           master     #657      +/-   ##==========================================- Coverage   90.42%   90.40%   -0.03%==========================================  Files          39       39                Lines        3510     3513       +3     ==========================================+ Hits         3174     3176       +2- Misses        336      337       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

n-thumann force-pushed theprefer_datetime_over_dateutil_python_3_11 branch from91eeb51 to9232a81Compare

May 18, 2024 23:16

n-thumann changed the title~~Improve performance in Python 3.11+ without ciso6801 extra~~perf: prefer datetime.fromisoformat over dateutil.parse in Python 3.11+

May 18, 2024

n-thumann changed the title~~perf: prefer datetime.fromisoformat over dateutil.parse in Python 3.11+~~perf: Prefer datetime.fromisoformat over dateutil.parse in Python 3.11+

May 18, 2024

n-thumann added2 commits

May 19, 2024 01:21