Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: deprecated urllib calls#655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
alespour merged 4 commits intomasterfromfix/deprecated-urllib-call
May 14, 2024
Merged

Conversation

alespour
Copy link
Contributor

@alespouralespour commentedMay 13, 2024•
edited
Loading

Closes#602

Proposed Changes

Replaces deprecatedurllib lib calls:

  • HTTPResponse.getheaders() with HTTPResponse.headers`
  • HTTPResponse.getheader(name, default) withHTTPResponse.headers.get(name, default)

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages areconventional

@alespouralespour changed the titleFix/deprecated urllib callfix: deprecated urllib callsMay 13, 2024
@alespouralespourforce-pushed thefix/deprecated-urllib-call branch fromeaed4e8 to99bdd38CompareMay 13, 2024 10:46
@codecov-commenter
Copy link

codecov-commenter commentedMay 13, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.42%. Comparing base(0047fa9) to head(05e1bf2).

❗ Your organization needs to install theCodecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@##           master     #655      +/-   ##==========================================+ Coverage   90.41%   90.42%   +0.01%==========================================  Files          39       39                Lines        3505     3510       +5     ==========================================+ Hits         3169     3174       +5  Misses        336      336

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@alespouralespour marked this pull request as ready for reviewMay 13, 2024 14:20
Copy link
Contributor

@karel-rehorkarel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Tests pass locally. Changes make sense,

@alespouralespour merged commit08acb17 intomasterMay 14, 2024
17 checks passed
@alespouralespour deleted the fix/deprecated-urllib-call branchMay 14, 2024 12:14
@bednarbednar added this to the1.43.0 milestoneMay 15, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@karel-rehorkarel-rehorkarel-rehor approved these changes

@bednarbednarAwaiting requested review from bednar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.

urllib3 v2.0.3 Deprecation Warnings onHTTPResponse.getheader() andHTTPResponse.getheaders()
4 participants
@alespour@codecov-commenter@karel-rehor@bednar
[8]ページ先頭
©2009-2025 Movatter.jp