Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: packaging type info#654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
alespour merged 2 commits intomasterfromfix/packaging-type-info
May 15, 2024
Merged

fix: packaging type info#654

alespour merged 2 commits intomasterfromfix/packaging-type-info
May 15, 2024

Conversation

alespour
Copy link
Contributor

@alespouralespour commentedMay 13, 2024•
edited
Loading

Closes#622

Proposed Changes

This adds PEP 561 distributing and packaging type information, which specifically resolves issue with MyPy
error: Skipping analyzing "influxdb_client": module is installed, but missing library stubs or py.typed marker [import-untyped]

The required marker really is just an empty filepy.typed. The same fix has been applied in v3 client.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages areconventional

@alespouralespour marked this pull request as ready for reviewMay 13, 2024 10:03
@alespouralespour marked this pull request as draftMay 14, 2024 11:25
@alespouralespourforce-pushed thefix/packaging-type-info branch from423c185 toe2dd513CompareMay 14, 2024 12:17
@codecov-commenter
Copy link

codecov-commenter commentedMay 14, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.42%. Comparing base(08acb17) to head(e2dd513).

❗ Your organization needs to install theCodecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@##           master     #654   +/-   ##=======================================  Coverage   90.42%   90.42%           =======================================  Files          39       39             Lines        3510     3510           =======================================  Hits         3174     3174             Misses        336      336

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@alespouralespour marked this pull request as ready for reviewMay 14, 2024 13:05
@alespouralespour merged commit51d6fa4 intomasterMay 15, 2024
17 checks passed
@alespouralespour deleted the fix/packaging-type-info branchMay 15, 2024 07:20
@bednarbednar added this to the1.43.0 milestoneMay 15, 2024
@max-accenta
Copy link

Hi, for some reason installing the package with the latest version (1.43) from pip does not install thepy.typed file. Steps to reproduce:

python -m venv venv. venv/bin/activatepython -m pip install influxdb_clientls -l venv/lib/python3.11/site-packages/influxdb_client| grep typed# Nothing

Installing directly from the repo works though (pip install git+https://github.com/influxdata/influxdb-client-python).
Thanks

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bednarbednarbednar approved these changes

@karel-rehorkarel-rehorAwaiting requested review from karel-rehor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.43.0
Development

Successfully merging this pull request may close these issues.

Missing Type Hints
4 participants
@alespour@codecov-commenter@max-accenta@bednar
[8]ページ先頭
©2009-2025 Movatter.jp