- Notifications
You must be signed in to change notification settings - Fork186
fix: serialize Pandas NaN values into LineProtocol#648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -20,7 +20,8 @@ def _itertuples(data_frame): | |||
| def _not_nan(x): | |||
| return x == x | |||
| from ...extras import pd | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I see this same import occurs on line 91. Wouldn't it be more efficient to import this once at the head of the file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@karel-rehor, nice catch! Thank you 👍. I've uploaded the fixed version.
codecov-commenter commentedApr 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install theCodecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@## master #648 +/- ##==========================================- Coverage 90.42% 90.41% -0.02%========================================== Files 39 39 Lines 3509 3505 -4 ==========================================- Hits 3173 3169 -4 Misses 336 336 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Tests pass. One small issue updated. Everything else looks OK.
Uh oh!
There was an error while loading.Please reload this page.
Closes#590
Proposed Changes
Fixed serialisation Pandas NaN values into LineProtocol.
Checklist
pytest testscompletes successfully