Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: dispose window scheduler#641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bednar merged 4 commits intomasterfromfix-scheduler
Feb 29, 2024
Merged

fix: dispose window scheduler#641

bednar merged 4 commits intomasterfromfix-scheduler
Feb 29, 2024

Conversation

bednar
Copy link
Contributor

@bednarbednar commentedFeb 2, 2024•
edited
Loading

Related#640

Proposed Changes

Dispose scheduler when disposingwrite_api.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages areconventional
  • SignCLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commentedFeb 2, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(293ed7f) 90.40% compared to head(46ec063) 90.42%.

❗ Your organization needs to install theCodecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@##           master     #641      +/-   ##==========================================+ Coverage   90.40%   90.42%   +0.01%==========================================  Files          39       39                Lines        3503     3509       +6     ==========================================+ Hits         3167     3173       +6  Misses        336      336

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Copy link
Contributor

@karel-rehorkarel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks correct.

@bednarbednar merged commit2661e4d intomasterFeb 29, 2024
@bednarbednar deleted the fix-scheduler branchFebruary 29, 2024 08:29
@bednarbednar added this to the1.41.0 milestoneFeb 29, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@karel-rehorkarel-rehorkarel-rehor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.41.0
Development

Successfully merging this pull request may close these issues.

3 participants
@bednar@codecov-commenter@karel-rehor
[8]ページ先頭
©2009-2025 Movatter.jp