Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Add__eq__ implementation to class Point#625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bednar merged 4 commits intoinfluxdata:masterfromhf-kklein:point-equality
Jan 4, 2024

Conversation

@hf-kklein
Copy link
Contributor

@hf-kkleinhf-kklein commentedJan 3, 2024•
edited
Loading

fixes#623

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages areconventional
  • SignCLA (if not already signed)

@bednarbednar changed the titleAdd__eq__ implementation to class Pointfeat: Add__eq__ implementation to class PointJan 4, 2024
Copy link
Contributor

@bednarbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@hf-kklein thanks for your PR 👍. Before we can proceed with accepting it, there are a few requirements that need to be met:

  1. Please satisfy ourChecklist:
    image

@hf-kkleinhf-kklein requested a review frombednarJanuary 4, 2024 09:20
@codecov-commenter
Copy link

codecov-commenter commentedJan 4, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(8286f45) 90.35% compared to head(9b34a51) 90.36%.

❗ Current head9b34a51 differs from pull request most recent headd32a35a. Consider uploading reports for the commitd32a35a to get more accurate results

❗ Your organization needs to install theCodecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@##           master     #625      +/-   ##==========================================+ Coverage   90.35%   90.36%   +0.01%==========================================  Files          39       39                Lines        3493     3497       +4     ==========================================+ Hits         3156     3160       +4  Misses        337      337

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Copy link
Contributor

@bednarbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks again for your PR 👍

LGTM 🚀

@bednarbednar added this to the1.40.0 milestoneJan 4, 2024
@bednarbednar merged commit024c1b1 intoinfluxdata:masterJan 4, 2024
@hf-kkleinhf-kklein deleted the point-equality branchJanuary 4, 2024 10:27
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@bednarbednarbednar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.40.0

Development

Successfully merging this pull request may close these issues.

class Point doesn't support equality comparison

3 participants

@hf-kklein@codecov-commenter@bednar
[8]ページ先頭
©2009-2025 Movatter.jp