- Notifications
You must be signed in to change notification settings - Fork182
fix: returnstr instead ofurllib3.HTTPResponse for `InfluxDBClie…#606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
6ae3a67 to0a4ae41Comparecodecov-commenter commentedAug 22, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## master #606 +/- ##==========================================- Coverage 90.30% 90.11% -0.20%========================================== Files 39 39 Lines 3456 3430 -26 ==========================================- Hits 3121 3091 -30- Misses 335 339 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jules-ch commentedAug 22, 2023
I had to use |
jules-ch commentedAug 22, 2023
Ready for review |
bednar left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi@jules-ch,
Thank you for your PR. Could you please update the CHANGELOG.md to indicate that this is a breaking change and provide guidance on how users should address it?
Thanks!
jules-ch commentedNov 10, 2023
Do you need me to introduce this as a BREAKING CHANGE. I'll document it as a Breaking change for now |
f024155 tocb5ff71Compare…nt.QueryAPI.query_raw`
cb5ff71 tof0c7ef4Comparejules-ch commentedNov 15, 2023
CI is failing because of a problem on CircleCI I think. Pipeline needs to be triggered again. |
Closes#569
Proposed Changes
As it is done in the Async version of the client, return
strresponse data as per the documentation.Checklist
pytest testscompletes successfully