Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: returnstr instead ofurllib3.HTTPResponse for `InfluxDBClie…#606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
jules-ch wants to merge2 commits intoinfluxdata:master
base:master
Choose a base branch
Loading
fromjules-ch:569-queryraw-return-type

Conversation

jules-ch
Copy link
Contributor

Closes#569

Proposed Changes

As it is done in the Async version of the client, returnstr response data as per the documentation.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages areconventional
  • SignCLA (if not already signed)

@jules-chjules-chforce-pushed the569-queryraw-return-type branch 2 times, most recently from6ae3a67 to0a4ae41CompareAugust 22, 2023 19:01
@codecov-commenter
Copy link

codecov-commenter commentedAug 22, 2023
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(2f9e5ed) 90.30% compared to head(0a4ae41) 90.31%.
Report is 8 commits behind head on master.

❗ Current head0a4ae41 differs from pull request most recent heada05c5b0. Consider uploading reports for the commita05c5b0 to get more accurate results

❗ Your organization needs to install theCodecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@##           master     #606   +/-   ##=======================================  Coverage   90.30%   90.31%           =======================================  Files          39       39             Lines        3456     3458    +2     =======================================+ Hits         3121     3123    +2  Misses        335      335

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@jules-ch
Copy link
ContributorAuthor

I had to use.data, using.read function with debug resulted with a bug when the response already read by the debugger it returned an empty string.
I'd have to check it is not the case with the async function.

@jules-ch
Copy link
ContributorAuthor

Ready for review

Copy link
Contributor

@bednarbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@jules-ch,

Thank you for your PR. Could you please update the CHANGELOG.md to indicate that this is a breaking change and provide guidance on how users should address it?

Thanks!

@jules-ch
Copy link
ContributorAuthor

Do you need me to introduce this as a BREAKING CHANGE.
Just want to wonfirm this, since the function was not returning the documented type in the first place.

I'll document it as a Breaking change for now

@jules-chjules-chforce-pushed the569-queryraw-return-type branch 2 times, most recently fromf024155 tocb5ff71CompareNovember 11, 2023 15:51
@jules-ch
Copy link
ContributorAuthor

CI is failing because of a problem on CircleCI I think. Pipeline needs to be triggered again.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ivankudibalivankudibalivankudibal approved these changes

@bednarbednarAwaiting requested review from bednar

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query_api.query_raw does not return str but urllib3.response.HTTPResponse object
5 participants
@jules-ch@codecov-commenter@bednar@ivankudibal@alespour

[8]ページ先頭

©2009-2025 Movatter.jp