Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: prevent creating unnecessary threads repeatedly#562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bednar merged 3 commits intoinfluxdata:masterfromgoznauk:patch-1
Jan 4, 2024

Conversation

goznauk
Copy link
Contributor

@goznaukgoznauk commentedFeb 22, 2023•
edited by bednar
Loading

Closes#561

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages areconventional
  • SignCLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commentedFeb 22, 2023•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(eb5afd1) 90.35% compared to head(ab4a528) 90.35%.

❗ Your organization needs to install theCodecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@##           master     #562   +/-   ##=======================================  Coverage   90.35%   90.35%           =======================================  Files          39       39             Lines        3493     3493           =======================================  Hits         3156     3156             Misses        337      337

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Copy link
Contributor

@bednarbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@goznauk thanks for your PR 👍. Can you please satisfy following Checklist:

image

@goznaukgoznaukforce-pushed thepatch-1 branch 3 times, most recently from65ee74b to24103c5CompareAugust 5, 2023 07:41
@goznaukgoznauk changed the titleUse ThreadPoolScheduler for WriteApi batch subjectfix: use thread pool for WriteApi batch to prevent creating threads repeatedlyAug 5, 2023
@goznaukgoznauk changed the titlefix: use thread pool for WriteApi batch to prevent creating threads repeatedlyfix: prevent creating unnecessary threads repeatedlyAug 5, 2023
@goznauk
Copy link
ContributorAuthor

@bednar Thank you for your feedback! I have completed all the items in the checklist as requested. Please let me know if there are any other requirements or changes needed for this PR.

@bednar
Copy link
Contributor

@goznauk thanks

@goznauk
Copy link
ContributorAuthor

@bednar any updates for this?

@bednar
Copy link
Contributor

@goznauk, I've added this PR to our backlog. We need to conduct a few manual tests on our end before we can proceed with merging this PR.

@bednarbednar self-assigned thisJan 3, 2024
Use ThreadPoolScheduler for WriteApi batch subject instead of TimeoutScheduler.Fixesinfluxdata#561
@bednar
Copy link
Contributor

@goznauk I've tested this PR and everything looks good

goznauk reacted with heart emoji

@bednarbednar added this to the1.40.0 milestoneJan 4, 2024
@bednarbednar merged commit8286f45 intoinfluxdata:masterJan 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@bednarbednarbednar approved these changes

Assignees

@bednarbednar

Labels
None yet
Projects
None yet
Milestone
1.40.0
Development

Successfully merging this pull request may close these issues.

WriteApi should use ThreadPoolScheduler for batching
3 participants
@goznauk@codecov-commenter@bednar
[8]ページ先頭
©2009-2025 Movatter.jp