- Notifications
You must be signed in to change notification settings - Fork3.7k
fix: Remove unused crates#26519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
carols10cents wants to merge2 commits intoinfluxdata:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
And move crates from regular to dev-dependencies when they're only usedin tests.Found by the unused crate lint and removed to help prevent unnecessarydependency hell when upgrading hyper to 1.0, but committed separatelyfrom enabling the lint permanently.
But allow/expect/explicitly `use as _` for false positives of the lintbecause it isn't possible to currently specify that a dependency is onlyused in unit tests but not integration tests, or only used in abenchmark but not unit tests, or only used in the bin but not the lib.See these issues:- <rust-lang/rust#57274>- <rust-lang/rust#95513>
hiltontj approved these changesJul 2, 2025
Contributor
hiltontj left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is a welcome change IMHO - though it has been some time since the PR was opened so a rebase/merge is needed.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And move crates from regular to dev-dependencies when they're only used in tests.
Found by the unused crate lint and removed to help prevent unnecessary dependency hell when upgrading hyper to 1.0, but committed separately from enabling the lint permanently.
This lint has a number of "false positives" that are due to being unable to specify per-target dependencies; see these issues for more info:
unused_crate_dependenciesfalse-positives in Cargo packages with muliple Cargo Targets (lib, bins, examples, tests, benches) rust-lang/rust#95513I'm most interested in the first commit here that cleans up existing unused crates.
I won't be offended if you don't want the second commit that will make you have to clean up or explicitly allow actual unused crates or false positives going forward. I'm happy to rebase out the 2nd commit, just say the word!