Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow to disable resolver#3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
bertho-zero wants to merge2 commits intoimport-js:main
base:main
Choose a base branch
Loading
frombertho-zero:patch-1

Conversation

bertho-zero
Copy link

@codecovCodecov
Copy link

codecovbot commentedNov 6, 2024
edited
Loading

Codecov Report

Attention: Patch coverage is66.66667% with1 line in your changes missing coverage. Please review.

Project coverage is 91.85%. Comparing base(67cc798) to head(bed542b).
Report is 3 commits behind head on main.

Files with missing linesPatch %Lines
utils/resolve.js66.66%1 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3096      +/-   ##==========================================+ Coverage   81.99%   91.85%   +9.86%==========================================  Files          94       83      -11       Lines        4154     3573     -581       Branches     1395     1249     -146     ==========================================- Hits         3406     3282     -124+ Misses        748      291     -457

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Copy link
Member

@ljharbljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This seems reasonable - although I thinkundefined is a better choice - and it will need tests.

@ljharbljharb added semver-minor package: utilseslint-module-utils package labelsNov 6, 2024
@ljharbljharb marked this pull request as draftNovember 6, 2024 19:06
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ljharbljharbljharb requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
package: utilseslint-module-utils packagesemver-minor
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to disable default resolver
2 participants
@bertho-zero@ljharb

[8]ページ先頭

©2009-2025 Movatter.jp