Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.6k
[PoC] Created FileEnumeratorIsh to demonstrate flat config support#2967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
JoshuaKGoldberg wants to merge1 commit intoimport-js:mainChoose a base branch fromJoshuaKGoldberg:file-enumerator-ish
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
cb90bd1
to9d677db
Compare1 task
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending as a reference for#2829 ->eslint/eslint#18087.
This:
FileEnumerator.js
from ESLint's source as aFileEnumeratorIsh
classFileEnumeratorIsh
instead of the existingFileEnumerator
imports inno-unused-modules.js
This code is not ready to be reviewed. It doesn't preserve existing licensing/ownership. And I don't work in this repository nearly enough to be confident all of those removals were ok to remove. It's just a reference to show that
isDirectoryIgnored
+isFileIgnored
seems to be enough for the rule to go off of.