Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.5k
Feature: no duplicates require#2931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Feature: no duplicates require#2931
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ljharb left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can we add some tests with a function that's called "require" but isn't the global one?
Pandemic1617 commentedDec 4, 2023
constrequire=(x)=>{};consta=require("./a.js"); This require would be detected as the global require even though it isn't. This is indeed a limitation of my implementation but I thought it would be acceptable since the following rules also have the same limitation:
|
ljharb commentedDec 4, 2023
Hmm - are there no rules thatdont have the limitation? |
Pandemic1617 commentedDec 4, 2023
I am not aware of any and even the |
implements detection of duplicate
requireimportsresolves#2925
Note that auto fix isn't implemented