Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.6k
upgrade minimatch to @5#2680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Since this is indeed a breaking change, we're highly unlikely to ever merge it unless there's avery compelling reason. How does the linked bug impact this plugin? |
Thank you for your quick response! For example, I want to loosen rules a bit for testing, but I can't. module.exports={plugins:['import'],rules:{'import/no-internal-modules':['error',{forbid:['@src/a/*/**']}],},overrides:[{files:['src/**/*.test.ts'],rules:{'import/no-internal-modules':['error',{forbid:['@src/a/*/!(__tests__)/**']}],}}]} As a user, it's very reasonable we can use glob expressions correctly. |
I'm quite unfamiliar with inline glob expressions like that - do they work in gitignore? As such, I have no idea what you're trying to forbid - and allow - with that glob. Can you elaborate? |
minimatch has fixed some bugs so I upgraded it to v5.
This includes breaking changes, and I think some of them are correct behavior as the glob pattern but I'am not sure that all of them are
https://www.digitalocean.com/community/tools/glob?comments=true&glob=app%2F%2A%2A%2F%2A%2A&matches=false&tests=app%2Fa
My main interest isthis bug.