Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

upgrade minimatch to @5#2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
m-shaka wants to merge2 commits intoimport-js:main
base:main
Choose a base branch
Loading
fromm-shaka:upgrade-minimatch

Conversation

m-shaka
Copy link

minimatch has fixed some bugs so I upgraded it to v5.
This includes breaking changes, and I think some of them are correct behavior as the glob pattern but I'am not sure that all of them are
https://www.digitalocean.com/community/tools/glob?comments=true&glob=app%2F%2A%2A%2F%2A%2A&matches=false&tests=app%2Fa

My main interest isthis bug.

@ljharb
Copy link
Member

Since this is indeed a breaking change, we're highly unlikely to ever merge it unless there's avery compelling reason.

How does the linked bug impact this plugin?

@ljharbljharb marked this pull request as draftJanuary 16, 2023 06:20
@m-shaka
Copy link
Author

Thank you for your quick response!

For example, I want to loosen rules a bit for testing, but I can't.

module.exports={plugins:['import'],rules:{'import/no-internal-modules':['error',{forbid:['@src/a/*/**']}],},overrides:[{files:['src/**/*.test.ts'],rules:{'import/no-internal-modules':['error',{forbid:['@src/a/*/!(__tests__)/**']}],}}]}

As a user, it's very reasonable we can use glob expressions correctly.
I know backward compatibility may concern you as a maintainer. I'll close this PR if there is another workaround

@ljharb
Copy link
Member

I'm quite unfamiliar with inline glob expressions like that - do they work in gitignore?

As such, I have no idea what you're trying to forbid - and allow - with that glob. Can you elaborate?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@m-shaka@ljharb

[8]ページ先頭

©2009-2025 Movatter.jp