Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: Sort all imports and activate eslint import rule#2119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jdeniau merged 3 commits intomainfromsort-imports
Jun 11, 2025

Conversation

@jdeniau
Copy link
Member

This may help reviewing#2105

@jdeniaujdeniau changed the titleUse eslint to sort importschore: Use eslint to sort importsJun 1, 2025
@jdeniaujdeniauforce-pushed thesort-imports branch 2 times, most recently from7913d17 tocd0fbadCompareJune 11, 2025 22:05
@jdeniau
Copy link
MemberAuthor

jdeniau commentedJun 11, 2025
edited
Loading

The diff did change as the import order did change.

It SHOULD be safe though to push that on main as the import order should not impact end user.

I ran copilot on that one to see if there is a side effect on the src dir, and here is the result:

After searching and scanning the entiresrc directory for side effects, here are the findings:

No files insrc directly reference or mutate global objects likeglobalThis,window, self, orglobal.
No files insrc usesetTimeout,setInterval,eval, or similar APIs that would cause top-level side effects.
The only use ofObject.defineProperty is inRecord.js andHash.js, but these are used to define properties on objects or prototypes, not on global objects. This is a standard, side-effect-free pattern unless the prototype is a global object (which it is not in this context).
No files insrc userequire orimport() in a way that would cause dynamic side effects.
The onlyconsole usage inRecord.js is for warnings, which is not a side effect that would impact library consumers.
No evidence of IIFEs, singletons, or top-level code that mutates global state.
Conclusion:
The code in thesrc directory does not contain side effects that would be affected by the order of import statements in your entry file. Sorting imports inImmutable.js is safe and will not impact end users.

@jdeniaujdeniau changed the titlechore: Use eslint to sort importschore: Sort all imports and activate eslint import ruleJun 11, 2025
@jdeniaujdeniau merged commitb3dee51 intomainJun 11, 2025
5 of 6 checks passed
@jdeniaujdeniau deleted the sort-imports branchJune 11, 2025 22:27
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jdeniau

[8]ページ先頭

©2009-2025 Movatter.jp