Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Map and Set sort and sortBy return type#2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jdeniau merged 2 commits intomainfrommap-set-sort-by-return-type
Oct 17, 2024

Conversation

@jdeniau
Copy link
Member

Fixes#2012

@jdeniau
Copy link
MemberAuthor

@cypherfunc

I did manage to fix#2012, but there is an issue in inheritance asSet::sort does not returnthis as specified in Collection.

At runtime this does work, but typescript prevents it at it flags it as an inheritance issue.
I did handle to make it work, but now the returned type isthis & OrderedSet<V>.

You can see a simple reproductible example of why onthis TS playground

Can you test this in your codebase to check if there is an issue ?

Thank you.

@jdeniaujdeniau added the awaiting-responseAwaiting response from creator. Can't fix without it. labelSep 24, 2024
Base automatically changed from5.x tomainOctober 17, 2024 22:04
An error occurred while trying to automatically change base from5.x tomainOctober 17, 2024 22:04
@jdeniaujdeniau merged commit2021417 intomainOct 17, 2024
@jdeniaujdeniau deleted the map-set-sort-by-return-type branchOctober 17, 2024 22:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting-responseAwaiting response from creator. Can't fix without it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Typescript return type of sort/sortBy on non-Ordered Collections isn't accurate

2 participants

@jdeniau

[8]ページ先頭

©2009-2025 Movatter.jp