NotificationsYou must be signed in to change notification settings
Fork866
Star28.7k

Add second large object test to check v8 non-fast properties#1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

markerikson merged 2 commits intomainfromfeature/more-benchmarks-3

Oct 27, 2025

Merged

Add second large object test to check v8 non-fast properties#1187

markerikson merged 2 commits intomainfromfeature/more-benchmarks-3

Oct 27, 2025

+37 −34

Conversation

Copy link

Collaborator

markerikson commentedOct 27, 2025

This PR:

Adds a second "large object" benchmark test with 3000 properties, as experimentation has showed there's a performance cliff in v8 around 1000 properties (likely due to its "fast properties" implementation switching behavior)
Tweaks some of the output formatting (removed some useless lines, fixed some wrapping)

Performance onmain as of this PR (with just the perf tweaks from#1164 merged), compared to the previous 10.1.x releases:

Strict iteration (current default in 10.2)

✓ immer10Perf shows an average 7.6% performance improvement over immer10┌─────────────────────┬──────────────┬──────────────┬─────────────┐│ Scenario            │ immer10      │ immer10Perf  │ Improvement │├─────────────────────┼──────────────┼──────────────┼─────────────┤│ mixed-sequence      │        9.4ms │        6.7ms │      +28.5% ││ update-largeObject1 │       15.2ms │       12.5ms │      +17.8% ││ update-largeObject2 │        2.1ms │        1.8ms │      +16.2% ││ update-reuse        │        8.6ms │        7.2ms │      +16.1% ││ remove-high-reuse   │        8.2ms │        7.0ms │      +15.2% ││ update-largeObject1 │      591.1µs │      521.1µs │      +11.8% ││ remove-reuse        │        8.5ms │        7.5ms │      +11.3% ││ update-largeObject2 │       27.8ms │       24.7ms │      +11.2% ││ rtkq-sequence       │       28.0ms │       25.1ms │      +10.3% ││ update-high-reuse   │        8.8ms │        7.9ms │       +9.7% ││ update              │       73.3µs │       67.2µs │       +8.2% ││ update-multiple     │       85.4µs │       79.3µs │       +7.1% ││ concat              │      173.1µs │      161.9µs │       +6.5% ││ remove-high         │      167.4µs │      160.9µs │       +3.8% ││ sortById-reverse    │      183.0µs │      176.1µs │       +3.8% ││ filter              │       97.7µs │       94.3µs │       +3.5% ││ add                 │       70.3µs │       70.0µs │       +0.3% ││ mapNested           │      175.8µs │      176.0µs │       -0.1% ││ remove              │      185.1µs │      192.9µs │       -4.3% ││ reverse-array       │      160.9µs │      174.4µs │       -8.4% ││ update-high         │      131.0µs │      142.2µs │       -8.5% │└─────────────────────┴──────────────┴──────────────┴─────────────┘

Loose iteration (opt-in now, default in v11)

✓ immer10Perf shows an average 20.7% performance improvement over immer10┌─────────────────────┬──────────────┬──────────────┬─────────────┐│ Scenario            │ immer10      │ immer10Perf  │ Improvement │├─────────────────────┼──────────────┼──────────────┼─────────────┤│ update-reuse        │        9.3ms │        4.4ms │      +52.4% ││ mixed-sequence      │        8.7ms │        4.7ms │      +46.7% ││ update-high-reuse   │       11.3ms │        6.1ms │      +45.8% ││ remove-reuse        │       12.2ms │        6.8ms │      +44.4% ││ remove-high-reuse   │        8.6ms │        5.3ms │      +38.6% ││ update-largeObject1 │       15.9ms │       10.6ms │      +33.3% ││ rtkq-sequence       │       31.9ms │       22.4ms │      +29.9% ││ concat              │      157.9µs │      115.8µs │      +26.6% ││ update-largeObject2 │       30.1ms │       22.1ms │      +26.4% ││ add                 │       83.2µs │       65.5µs │      +21.4% ││ update-largeObject1 │      572.2µs │      462.1µs │      +19.2% ││ update-largeObject2 │        2.0ms │        1.7ms │      +16.5% ││ filter              │      107.5µs │       90.3µs │      +16.0% ││ update              │       70.5µs │       59.3µs │      +15.8% ││ update-multiple     │       85.0µs │       72.0µs │      +15.3% ││ update-high         │      131.9µs │      131.6µs │       +0.3% ││ sortById-reverse    │      188.6µs │      189.0µs │       -0.2% ││ mapNested           │      171.6µs │      173.9µs │       -1.4% ││ reverse-array       │      170.1µs │      176.0µs │       -3.5% ││ remove              │      173.0µs │      179.1µs │       -3.5% ││ remove-high         │      148.0µs │      154.9µs │       -4.6% │└─────────────────────┴──────────────┴──────────────┴─────────────┘