- Notifications
You must be signed in to change notification settings - Fork377
move platform and renderer backends out of Dear Imgui#821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Store the objects containing the callback methods for multi viewportsupport in two globals that are managed by imgui-rs, instead of usingBackendPlatformUserdata and BackendRendererUserDatafixesimgui-rs#820
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm! thank you for your hard work!
Note: CI failed, but this is because we'll need to bump MSRV which we've needed to do for awhile. I am going to merge this and then immediately bump MSRV on main. |
38f6f32 intoimgui-rs:mainUh oh!
There was an error while loading.Please reload this page.
Store the objects containing the callback methods for multi viewport
support in two crate globals that are managed by imgui-rs, instead of using
BackendPlatformUserdata and BackendRendererUserData
fixes#820