- Notifications
You must be signed in to change notification settings - Fork330
Add support for scanning QR codes#199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
c2ec236 tod28ac26Compare0d193b1 tob8bb2eeCompare| /** | ||
| The stored meta data output; used to detect QR codes. | ||
| */ | ||
| privatevarqrOutput:AVCaptureOutput?=nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@phlippieb it seems that qrOutput is always nil. Could it be that in line 815 it should be qrOutput instead of output?
Right now there is an issue when you call stopQRCodeDetection() directly in the handler and then startQRCodeDetection(). By starting QR code detection the following times, it will not work again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This was so long ago, I have no idea anymore 😁 it's totally possible. Is your issue fixed if you change line 815 to qrOutput?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@phlippieb I fixed it in PR#237. Please check it out :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This isn't my repo 😺
Probably not quite how you would have done it, but this is something we added for our own use, and I figured let's propose this as functionality on this great project 😄