Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Object Mother pattern #498#503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iluwatar merged 7 commits intoiluwatar:masterfromigeligel:master
Nov 26, 2016
Merged

Object Mother pattern #498#503

iluwatar merged 7 commits intoiluwatar:masterfromigeligel:master
Nov 26, 2016

Conversation

igeligel
Copy link
Contributor

Added the object mother pattern and all diagrams to the context.

Add a simple king and queen classes which implement the behaviour of theroyalty interface. Also wrote the object mother of royalty objects whichis final so you can just call the static methods in it to create objectswith a specific state to use them fast in tests. The tests are alreadycreated for testing the behaviour and the type of the objects which arecreated by the object mother.I also created the UML diagrams via object aid and updated the readme.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 84.331% when pulling863ea75 on igeligel:master into4ca205c on iluwatar:master.

@iluwatar
Copy link
Owner

Theobject-mother module has not been added to the parentpom.xml.


@Test
public void queenIsBlockingFlirtCauseDrunkKing() {
King soberUnhappyKing = RoyaltyObjectMother.createDrunkKing();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Confusing naming here


@Test
public void queenIsBlockingFlirt() {
King soberUnhappyKing = RoyaltyObjectMother.createHappyKing();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Confusing naming here


@Test
public void successfullKingFlirt() {
King soberUnhappyKing = RoyaltyObjectMother.createHappyKing();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Confusing naming here

Copy link
Owner

@iluwatariluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@igeligel you have my review comments. Just a couple of minor mistakes found. Please fix them and the pattern is ready for merging.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 83.382% when pulling6aed26e on igeligel:master into19cb715 on iluwatar:master.

@iluwatar
Copy link
Owner

@igeligel is this ready for another review?

@igeligel
Copy link
ContributorAuthor

Yeah, i have messed up the pom.xml at some commit but fixed it then. I also renamed the code parts where you wanted a change.

@iluwatariluwatar merged commitcc02ff4 intoiluwatar:masterNov 26, 2016
@iluwatar
Copy link
Owner

Looks good@igeligel. Thanks for the contribution!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iluwatariluwatariluwatar requested changes

Assignees

@iluwatariluwatar

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@igeligel@coveralls@iluwatar

[8]ページ先頭

©2009-2025 Movatter.jp