Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Reactor #74 implemented#242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
npathai merged 18 commits intomasterfromReactor
Sep 16, 2015
Merged

Reactor #74 implemented#242

npathai merged 18 commits intomasterfromReactor
Sep 16, 2015

Conversation

npathai
Copy link
Contributor

I have implemented#74 using Java NIO framework. Currently the Reactor only supports server mode.

Tasks:

  • Implement design pattern and tests
  • Documentation
  • Google Style Guide (done partially)
  • Web site
  • Class diagram

@npathai
Copy link
ContributorAuthor

JDP team please review.

@iluwatar
Copy link
Owner

@npathai In general it looks great. I will review in more detail at earliest

  • Put under review badge to the pull request
  • Does the example code implement the pattern correctly?
  • Does the example code have enough test coverage?
  • Is the example code commented well enough?
  • Is the example code following JavaDoc conventions?
  • Are the project coding conventions being followed?
  • Is the class diagram generated correctly?
  • Is the index.md implemented correctly so the pattern will show correctly on the web site?

@npathai
Copy link
ContributorAuthor

@iluwatar Thanks. No problem. Take your time.

* The application utilizes single thread to listen for requests on all ports. It does not create
* a separate thread for each client, which provides better scalability under load (number of clients
* increase).
*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would like to read about the participants of the pattern here. Handles, synchronous event demultiplexer, initiation dispatcher and event handlers - what class in the example implements what? I saw you have good comments on the actual classes, maybe some of that description can be put here also.

@npathai
Copy link
ContributorAuthor

@iluwatar thts immature of me nt to take care of final.. I relied on eclipse behavior.. By somehow I seem to have changed d settings... Will take care of that 2moro..

@iluwatar
Copy link
Owner

I'm sorry for the late review 😞 You should now catch up the master branch, this is no longer up to date.

@iluwatar
Copy link
Owner

I'm done reviewing for now.

@npathai
Copy link
ContributorAuthor

All done. I have left comments on your points. Awaiting further comments :)

@iluwatar
Copy link
Owner

It's ok now. We only need the class diagram andindex.md.

@npathai
Copy link
ContributorAuthor

@iluwatar Done. Added class diagram and index.md. Please review.

@iluwatar
Copy link
Owner

Looks fine@npathai Feel free to merge!

…names were added due to default eclipse configuration.
npathai added a commit that referenced this pull requestSep 16, 2015
Reactor#74 implemented using Java NIO framework.
@npathainpathai merged commite5f1ff1 intomasterSep 16, 2015
@npathainpathai deleted the Reactor branchSeptember 16, 2015 06:16
@npathainpathai mentioned this pull requestSep 16, 2015
pratigya0 pushed a commit to pratigya0/java-design-patterns that referenced this pull requestAug 3, 2023
Co-authored-by: Атаи Рустам Бахтиярович <ratai@borlas.ru>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@npathai@iluwatar
[8]ページ先頭
©2009-2025 Movatter.jp