- Notifications
You must be signed in to change notification settings - Fork121
add support for "lightbulbs" connected to Hue#142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:dev
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-io commentedJul 27, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## dev #142 +/- ##======================================= Coverage 52.08% 52.08% ======================================= Files 15 15 Lines 1342 1342 Branches 138 138 ======================================= Hits 699 699 Misses 628 628 Partials 15 15 |
ikalchev left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi and thanks for the contrib. Also sorry for the delay! Can you leave just the accessory in this file so that users can just use the main.py and import this module?
| from pyhap.accessory_driver import AccessoryDriver | ||
| from pyhap.const import CATEGORY_LIGHTBULB | ||
| logging.basicConfig(level=logging.INFO) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe leave this to the module that starts HAP, e.g. the main.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If you decide to remove it, can you uselogger = logging.getLogger(__name__)
| self.id = id | ||
| def __setstate__(self, state): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This method is not needed now (if you don't plan to pickle the accessory)
This is a basic accessory discovering lightbulbs connected to a Hue Bridge and exposes them to HomeKit.