- Notifications
You must be signed in to change notification settings - Fork98
Add function to count and find problems with missing tests#96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Add function to count and find problems with missing tests#96
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Love it! Thanks!
Test.js Outdated
| return problems; | ||
| }; | ||
| const test_all = async function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you rename the following functions?
test_all->runAllTestssolve->solveProblem
Also, let's usecamelCase everywhere. I noticed we have a mix. A linter rule could solve this too (not need to do it here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
updated all variables and functions in this file to becamelCase
I also added the eslint rule to make it visible and noticed there are a lot of issues
I can create another PR to solve all of those linter issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Love it! that'd be amazing.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice! thank you.
96a9cfd intoignacio-chiazzo:masterUh oh!
There was an error while loading.Please reload this page.
What was added
An output to the console when you run all the tests so you can see how many problems are there and if there is any missing Test
Thanks to this I figured out that 2 of the test files had wrong naming
example output:
Checklist before requesting a review
npx eslint LeetcodeProblems LeetcodeProblemsTests) and unit tests (node Test.js) and they pass.More info.Check theguide andthis PR example.