Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1.2k
Nix/module: add defaultSettings#9939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Are you sure we need
I am assuming hyprland does set these as uwsm wants and therefore the manual finalize shouldn't be needed I am assuming this since I don't use this finalize command and I haven't faced any issues regarding unset |
It may be a remnant from the early days of uwsm support, as it was needed sometimes to properly finish setting up the session. If it's no longer needed, I'll remove it. |
Another possible approach would be to have a toggle But I believe this would hurt visibility, as having the option an attrset directly shows its value as |
Uh oh!
There was an error while loading.Please reload this page.
Describe your PR, what does it fix/add?
TO BE MERGED AFTER#9930
Add
defaultSettings
option in the NixOS module. Can be disabled by setting it to{}
.Default settings currently includes allowing screencopy for XDPH and grim, and optionally adding
exec-once = uwsm finalize
in casewithUWSM = true
.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Brainstorming is welcome. This is what made sense to me at the time of opening this PR.
Is it ready for merging, or does it need work?
Untested, no.