Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Nix/module: add defaultSettings#9939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
fufexan wants to merge1 commit intohyprwm:main
base:main
Choose a base branch
Loading
fromfufexan:nix-permission-mgr

Conversation

fufexan
Copy link
Member

@fufexanfufexan commentedApr 6, 2025
edited
Loading

Describe your PR, what does it fix/add?

TO BE MERGED AFTER#9930

AdddefaultSettings option in the NixOS module. Can be disabled by setting it to{}.

Default settings currently includes allowing screencopy for XDPH and grim, and optionally addingexec-once = uwsm finalize in casewithUWSM = true.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Brainstorming is welcome. This is what made sense to me at the time of opening this PR.

Is it ready for merging, or does it need work?

Untested, no.

@fxzzi
Copy link
Contributor

Are you sure we needuwsm finalize? According to the uwsm docs it states:

TLDR; if your compositor puts WAYLAND_DISPLAY (and along with it DISPLAY, or other important or useful variables) into systemd activation environment, uwsm will make everything work automagically, proceed to section 3.

Otherwise configure compositor to run uwsm finalize command at the end of its startup. It will deal with putting WAYLAND_DISPLAY and DISPLAY (if set) variables into activation environments in the best possible ways and signal unit readiness to systemd.

I am assuming hyprland does set these as uwsm wants and therefore the manual finalize shouldn't be needed

I am assuming this since I don't use this finalize command and I haven't faced any issues regarding unsetWAYLAND_DISPLAY orDISPLAY, let me know if I'm incorrect here though.

@fufexan
Copy link
MemberAuthor

It may be a remnant from the early days of uwsm support, as it was needed sometimes to properly finish setting up the session.

If it's no longer needed, I'll remove it.

@fufexan
Copy link
MemberAuthor

Another possible approach would be to have a toggleenableDefaultConfig explaining what settings are being added, since it's something you either want or don't want.

But I believe this would hurt visibility, as having the option an attrset directly shows its value asdefault.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@fufexan@fxzzi

[8]ページ先頭

©2009-2025 Movatter.jp