- Notifications
You must be signed in to change notification settings - Fork663
fix(hld): use correct path for global slash commands#875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
CLAassistant commentedNov 27, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Important
Looks good to me! 👍
Reviewed everything up to4934db4 in 45 seconds. Click for details.
- Reviewed
26lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify yoursettings andrules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1.hld/api/handlers/sessions.go:1622
- Draft comment:
Good fix – global slash commands now correctly use ~/.claude/commands. Removing the CLAUDE_CONFIG_DIR fallback resolves the discovery issue. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2.hld/api/handlers/sessions.go:1624
- Draft comment:
Consider logging or handling the error case when os.UserHomeDir() fails so that issues with resolving the user’s home directory aren’t silently ignored. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID:wflow_AwYtZ7lcSNPmMwUf
You can customize by changing yourverbosity settings, reacting with 👍 or 👎,replying to comments, or addingcode review rules.
testower commentedNov 27, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I don't know if this is the correct solution, as I'm new to this codebase, but it works (tm). |
Global slash commands were not being discovered because hld waslooking in ~/.config/claude-code/commands instead of ~/.claude/commandswhere Claude Code actually stores them.CLAUDE_CONFIG_DIR is still respected as an override when set.🤖 Generated with [Claude Code](https://claude.com/claude-code)Co-Authored-By: Claude <noreply@anthropic.com>
4934db4 to9524458Compare
Uh oh!
There was an error while loading.Please reload this page.
What problem(s) was I solving?
Fixes#841
Global slash commands from
~/.claude/commandswere not being discovered in CodeLayer. Users saw "Failed to load commands" when typing/.The root cause was that hld was looking for global commands at
~/.config/claude-code/commandsinstead of~/.claude/commandswhere Claude Code actually stores them.What user-facing changes did I ship?
Global slash commands now appear correctly when typing
/in CodeLayer.How I implemented it
Changed the default global commands path in
hld/api/handlers/sessions.gofrom:~/.config/claude-code/commands(incorrect default)To:
~/.claude/commands(matching Claude Code's actual location)CLAUDE_CONFIG_DIRis still respected as an override when set, providing flexibility for non-standard configurations.Updated tests to use the correct default path.
How to verify it
make check testpasses.mdfile in~/.claude/commands/and verify it appears when typing/in CodeLayerCLAUDE_CONFIG_DIRto a custom path and verify commands are discovered from$CLAUDE_CONFIG_DIR/commandsDescription for the changelog
Fixed global slash commands not being discovered from
~/.claude/commandsA picture of a cute animal (not mandatory but encouraged)
🦔