- Notifications
You must be signed in to change notification settings - Fork661
feat: add Escape and Ctrl+[ hotkeys for blurring input#821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
0xjgv wants to merge1 commit intohumanlayer:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Updated HOTKEYS.md to include new hotkeys for blurring response input.- Enhanced HotkeyPanel to display Escape and Ctrl+[ as blur input options.- Modified ActiveSession and ResponseEditor components to handle new hotkey actions.
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Important
Looks good to me! 👍
Reviewed everything up to40605a5 in 1 minute and 8 seconds. Click for details.
- Reviewed
48lines of code in4files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify yoursettings andrules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1.humanlayer-wui/docs/HOTKEYS.md:223
- Draft comment:
New hotkeys (Escape and Ctrl+[) are added to the docs and match expected behavior. Ensure consistency with UI behavior. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2.humanlayer-wui/src/components/HotkeyPanel.tsx:70
- Draft comment:
Added hotkeyData entries for 'Escape' and 'Ctrl+['. Confirm the display text ('Ctrl+[') matches the key binding syntax used elsewhere. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3.humanlayer-wui/src/components/internal/SessionDetail/components/ActiveSession.tsx:323
- Draft comment:
The useHotkeys hook now listens for 'escape, ctrl+[' to trigger blurring. The conditional check for dialog elements is clear; verify that key naming ('escape' and 'ctrl+[') remains consistent across components. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4.humanlayer-wui/src/components/internal/SessionDetail/components/ResponseEditor.tsx:424
- Draft comment:
In the KeyboardShortcuts extension, new bindings for 'Escape' and 'Ctrl-[' call editor.commands.blur(). Ensure that the key formatting ('Ctrl-[') is consistently interpreted across the app. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID:wflow_eqdZoEwZYcllFYNW
You can customize by changing yourverbosity settings, reacting with 👍 or 👎,replying to comments, or addingcode review rules.
ContributorAuthor
0xjgv commentedOct 30, 2025
@dexhorthy thoughts? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
What problem(s) was I solving?
What user-facing changes did I ship?
How I implemented it
How to verify it
make check testpassesDescription for the changelog
A picture of a cute animal (not mandatory but encouraged)
Important
Add
EscapeandCtrl+[hotkeys for blurring input inActiveSession.tsxandResponseEditor.tsx, with documentation and UI updates.EscapeandCtrl+[hotkeys to blur response input inActiveSession.tsxandResponseEditor.tsx.HOTKEYS.mdto document new hotkeys.HotkeyPanel.tsxto displayEscapeandCtrl+[as blur input options.useHotkeysinActiveSession.tsxto handleescape, ctrl+[for blurring input.KeyboardShortcutsinResponseEditor.tsxto includeEscapeandCtrl-[for blurring input.This description was created by
for40605a5. You cancustomize this summary. It will automatically update as commits are pushed.