generated fromfastai/nbdev_template
- Notifications
You must be signed in to change notification settings - Fork2k
[WIP] Fix ppo example accelerator initialization error#3732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
ccs96307 wants to merge4 commits intohuggingface:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR leverages the parent class'
create_accelerator_and_postprocessmethod to initialize theacceleratorcorrectly, without overhauling thePPOTrainerinitialization flow.create_accelerator_and_postprocessinstead of manual accelerator setup.--gradient_accumulation_steps, whereas ZeRO Stage 2 and 3 require --gradient_accumulation_steps == 1.Note: With
--gradient_accumulation_steps > 1, running with ZeRO stage 2 or 3 still trigger the well-known error:The related issues as follows:
Request for feedback
Combine fixes?
should this PR also address the
no_syncwith ZeRO 2/3 compatibility (i.e. implement a workaround or guard), or…Separate the issue
open a new issue for the ZeRO compatibility problem and keep this PR focused solely on "accelerator initialization"?
Any guidance or opinions are greatly appreciated -- thank you! 🙏
Fixes # (issue)
#2377
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.