- Notifications
You must be signed in to change notification settings - Fork964
Added request_options parameter to various classes and functions for canceling requests#1190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xenova commentedFeb 12, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This can be very useful! Thanks! Regarding the API, since this is pretty non-standard for the python library, perhaps a better approach would be to allow the user to pass their own In fact, I think this would be better at the |
You're right, I need some time to revisit it. |
I added a custom fetch method, but after some thought, I realized that I still need to pass request_options as I do currently. Otherwise, every time an AbortController is used, I would need to reset env.customFetch, and there would be no way to cancel only specific fetches. |
Uh oh!
There was an error while loading.Please reload this page.
Added request_options parameter to various classes and functions for canceling requests
closed#1182