Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added request_options parameter to various classes and functions for canceling requests#1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
emojiiii wants to merge2 commits intohuggingface:main
base:main
Choose a base branch
Loading
fromemojiiii:feature-support-abort

Conversation

emojiiii
Copy link
Contributor

@emojiiiiemojiiii commentedFeb 12, 2025
edited
Loading

Added request_options parameter to various classes and functions for canceling requests

closed#1182

@xenova
Copy link
Collaborator

xenova commentedFeb 12, 2025
edited
Loading

This can be very useful! Thanks! Regarding the API, since this is pretty non-standard for the python library, perhaps a better approach would be to allow the user to pass their ownfetch function instead of only allowing them to pass options? This could be useful for loading models from custom filesystems too.

In fact, I think this would be better at theenv level. something likeenv.fetch = ...

@emojiiii
Copy link
ContributorAuthor

This can be very useful! Thanks! Regarding the API, since this is pretty non-standard for the python library, perhaps a better approach would be to allow the user to pass their ownfetch function instead of only allowing them to pass options? This could be useful for loading models from custom filesystems too.

In fact, I think this would be better at theenv level. something likeenv.fetch = ...

You're right, I need some time to revisit it.

xenova reacted with thumbs up emoji

@emojiiii
Copy link
ContributorAuthor

I added a custom fetch method, but after some thought, I realized that I still need to pass request_options as I do currently. Otherwise, every time an AbortController is used, I would need to reset env.customFetch, and there would be no way to cancel only specific fetches.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There is no way to stop / abort / cancel a pipeline()
2 participants
@emojiiii@xenova

[8]ページ先頭

©2009-2025 Movatter.jp