Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix multi-modality apply chat template issue#3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
sywangyi wants to merge1 commit intohuggingface:main
base:main
Choose a base branch
Loading
fromsywangyi:fix_open_ai_chat_completion

Conversation

sywangyi
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read thecontributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or theforum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@sywangyi
Copy link
ContributorAuthor

@regisss@Narsil please help review

@sywangyisywangyi changed the titlefix multi-modality apply template issuefix multi-modality apply chat template issueJun 6, 2025
@regisss
Copy link
Collaborator

@sywangyi Can you add a description of the issue and how this PR solves it please?

@sywangyi
Copy link
ContributorAuthor

sywangyi commentedJun 12, 2025
edited
Loading

#3257 describe it, And I just give a WA as skipping applying chat template to VLM model like llava qwenvl

@regisss
Copy link
Collaborator

Gently pinging@Narsil for review

@Narsil
Copy link
Collaborator

This is most likely a wrong fix. We cannot just skip using templates on some models because the answer is not to our liking.

We need to fix the template instead, no ? But overriding like this is most likely purely wrong.

@sywangyi
Copy link
ContributorAuthor

VLM template input like,
conversation = [
{

  "role": "user",  "content": [      {"type": "text", "text": "What is shown in this image?"},      {"type": "image"},    ],},

]

which is different with llm.
{"role": "user", "content": "Who are you?"},

so we may need reconstruct the msg for vlm before apply chat template. also, there is model that does not have chat template. we need to handle it as well.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@sywangyi@regisss@Narsil

[8]ページ先頭

©2009-2025 Movatter.jp