- Notifications
You must be signed in to change notification settings - Fork1.2k
wip: comment out prepend full_text#3079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
if let Some(token) = authorization_token { | ||
builder = builder.with_token(Some(token)); | ||
} | ||
let mut builder = ApiBuilder::new() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this chunk will be reversed, sorry it got in here
What you did here is effectively deactivate its job. Which is really simply to decode all the decoder tokens, instead of only the new ones. I was under the impression that T5 was a encoder/decoder model so I'm surprised to see a decoder-only model here. I'm pretty sure the "bug" will simply end up being a tokenizer issue, where possibly you're hitting a very old T5 non flash version that doesn't support some flags used in those tokenizers. Thanks for the fix for your use case, I'll leave it up for others to see, but if we're going to fix it, we need to find the root cause and fix that instead. |
@Narsil thanks for looking into this and explaining it to me to give me a sense of what the root of the problem could be. it was nice to see madlad being served with good results and may just use this for the time being. looking forward to tracking this solution and learning more about this great project💪 |
josh-at-straker commentedJun 18, 2025
Any movement on this one? Would be excellent to fully support MadLad as a translation T5 model. |
Uh oh!
There was an error while loading.Please reload this page.
What does this PR do?
This is an investigation as to why using
"return_full_text": true
as a parameter in hitting the/generate
endpoint produces a valid translation while running madlad400Background:#1416 (comment)
Fixes#1416
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.