- Notifications
You must be signed in to change notification settings - Fork1.2k
add intel xpu support for TGI#1475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Overall looks pretty good ! I think we'll move to propre enum |
thanks very much@Narsil and@OlivierDehaene for your comment. adding@yao-matrix |
@Narsil@OlivierDehaene I add xpu smi in env runtime, do you think is it proper to add this? this is to dump intel XPU version. |
It's OK in the current iteration (since showing N/A on most systems). |
Feel free to open up the draft whenever you're OK so we can run the tests + merge. |
@Narsil could you review the PR？done by my side. |
@Narsil@mfuntowicz CI node is ready, could we move on? |
yao-matrix commentedApr 25, 2024
@Narsil@mfuntowicz , pls feel free to let us know any issues, since CI is ready, I think we can launch CI and merge this PR, thx. cc@kding1 |
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
martinigoyanes pushed a commit to martinigoyanes/text-generation-inference that referenced this pull requestApr 30, 2024
# What does this PR do?<!--Congratulations! You've made it this far! You're not quite done yetthough.Once merged, your PR is going to appear in the release notes with thetitle you set, so make sure it's a great title that fully reflects theextent of your awesome contribution.Then, please replace this with a description of the change and whichissue is fixed (if applicable). Please also include relevant motivationand context. List any dependencies (if any) that are required for thischange.Once you're done, someone will review your PR shortly (see the section"Who can review?" below to tag some potential reviewers). They maysuggest changes to make the code even better. If no one reviewed your PRafter a week has passed, don't hesitate to post a new comment@-mentioning the same persons---sometimes notifications get lost.--><!-- Remove if not applicable -->Fixes # (issue)## Before submitting- [ ] This PR fixes a typo or improves the docs (you can dismiss theother checks if that's the case).- [ ] Did you read the [contributorguideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests), Pull Request section?- [ ] Was this discussed/approved via a Github issue or the[forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case.- [ ] Did you make sure to update the documentation with your changes?Here are the[documentationguidelines](https://github.com/huggingface/transformers/tree/main/docs),and[here are tips on formattingdocstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).- [ ] Did you write any new necessary tests?## Who can review?Anyone in the community is free to review the PR once the tests havepassed. Feel free to tagmembers/contributors who may be interested in your PR.<!-- Your PR will be replied to more quickly if you can figure out theright person to tag with @@OlivierDehaene OR@Narsil -->---------Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>Co-authored-by: Morgan Funtowicz <funtowiczmo@gmail.com>Co-authored-by: Nicolas Patry <patry.nicolas@protonmail.com>
Nilabhra pushed a commit to TII-AI-Research-Center/text-generation-inference that referenced this pull requestMay 14, 2024
# What does this PR do?<!--Congratulations! You've made it this far! You're not quite done yetthough.Once merged, your PR is going to appear in the release notes with thetitle you set, so make sure it's a great title that fully reflects theextent of your awesome contribution.Then, please replace this with a description of the change and whichissue is fixed (if applicable). Please also include relevant motivationand context. List any dependencies (if any) that are required for thischange.Once you're done, someone will review your PR shortly (see the section"Who can review?" below to tag some potential reviewers). They maysuggest changes to make the code even better. If no one reviewed your PRafter a week has passed, don't hesitate to post a new comment@-mentioning the same persons---sometimes notifications get lost.--><!-- Remove if not applicable -->Fixes # (issue)## Before submitting- [ ] This PR fixes a typo or improves the docs (you can dismiss theother checks if that's the case).- [ ] Did you read the [contributorguideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests), Pull Request section?- [ ] Was this discussed/approved via a Github issue or the[forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case.- [ ] Did you make sure to update the documentation with your changes?Here are the[documentationguidelines](https://github.com/huggingface/transformers/tree/main/docs),and[here are tips on formattingdocstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).- [ ] Did you write any new necessary tests?## Who can review?Anyone in the community is free to review the PR once the tests havepassed. Feel free to tagmembers/contributors who may be interested in your PR.<!-- Your PR will be replied to more quickly if you can figure out theright person to tag with @@OlivierDehaene OR@Narsil -->---------Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>Co-authored-by: Morgan Funtowicz <funtowiczmo@gmail.com>Co-authored-by: Nicolas Patry <patry.nicolas@protonmail.com>
kdamaszk pushed a commit to kdamaszk/tgi-gaudi that referenced this pull requestJun 10, 2024
<!--Congratulations! You've made it this far! You're not quite done yetthough.Once merged, your PR is going to appear in the release notes with thetitle you set, so make sure it's a great title that fully reflects theextent of your awesome contribution.Then, please replace this with a description of the change and whichissue is fixed (if applicable). Please also include relevant motivationand context. List any dependencies (if any) that are required for thischange.Once you're done, someone will review your PR shortly (see the section"Who can review?" below to tag some potential reviewers). They maysuggest changes to make the code even better. If no one reviewed your PRafter a week has passed, don't hesitate to post a new comment@-mentioning the same persons---sometimes notifications get lost.--><!-- Remove if not applicable -->Fixes # (issue)- [ ] This PR fixes a typo or improves the docs (you can dismiss theother checks if that's the case).- [ ] Did you read the [contributorguideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests), Pull Request section?- [ ] Was this discussed/approved via a Github issue or the[forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case.- [ ] Did you make sure to update the documentation with your changes?Here are the[documentationguidelines](https://github.com/huggingface/transformers/tree/main/docs),and[here are tips on formattingdocstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).- [ ] Did you write any new necessary tests?Anyone in the community is free to review the PR once the tests havepassed. Feel free to tagmembers/contributors who may be interested in your PR.<!-- Your PR will be replied to more quickly if you can figure out theright person to tag with @@OlivierDehaene OR@Narsil -->---------Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>Co-authored-by: Morgan Funtowicz <funtowiczmo@gmail.com>Co-authored-by: Nicolas Patry <patry.nicolas@protonmail.com>
kdamaszk pushed a commit to kdamaszk/tgi-gaudi that referenced this pull requestJun 10, 2024
<!--Congratulations! You've made it this far! You're not quite done yetthough.Once merged, your PR is going to appear in the release notes with thetitle you set, so make sure it's a great title that fully reflects theextent of your awesome contribution.Then, please replace this with a description of the change and whichissue is fixed (if applicable). Please also include relevant motivationand context. List any dependencies (if any) that are required for thischange.Once you're done, someone will review your PR shortly (see the section"Who can review?" below to tag some potential reviewers). They maysuggest changes to make the code even better. If no one reviewed your PRafter a week has passed, don't hesitate to post a new comment@-mentioning the same persons---sometimes notifications get lost.--><!-- Remove if not applicable -->Fixes # (issue)- [ ] This PR fixes a typo or improves the docs (you can dismiss theother checks if that's the case).- [ ] Did you read the [contributorguideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#start-contributing-pull-requests), Pull Request section?- [ ] Was this discussed/approved via a Github issue or the[forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case.- [ ] Did you make sure to update the documentation with your changes?Here are the[documentationguidelines](https://github.com/huggingface/transformers/tree/main/docs),and[here are tips on formattingdocstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation).- [ ] Did you write any new necessary tests?Anyone in the community is free to review the PR once the tests havepassed. Feel free to tagmembers/contributors who may be interested in your PR.<!-- Your PR will be replied to more quickly if you can figure out theright person to tag with @@OlivierDehaene OR@Narsil -->---------Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>Co-authored-by: Morgan Funtowicz <funtowiczmo@gmail.com>Co-authored-by: Nicolas Patry <patry.nicolas@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.