Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove default--model-id argument#679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
alvarobartt wants to merge1 commit intomain
base:main
Choose a base branch
Loading
fromunset-default-model-id

Conversation

alvarobartt
Copy link
Member

What does this PR do?

This PR removes the default value for the--model-id in theclap CLI i.e., the entrypoint for Text Embeddings Inference (TEI), to prevent cases where the model is not captured correctly from e.g. an environment variable, and theBAAI/bge-large-en-v1.5 model is served instead without specific definition from the user, which can be misleading / confusing in some scenarios.

Note

Since this PR represents somehow a "breaking change", the PR should be released within a minor version i.e., 1.8.0 if within the next release.

What's missing?

  • Once the PR is approved, update the--help outputs over the documentation and theREADME.md so that those are consistent with the latest CLI.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read thecontributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue or theforum? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are thedocumentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@Narsil

vrdn-23 reacted with heart emoji
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@alvarobartt

[8]ページ先頭

©2009-2025 Movatter.jp