Hi@juliendenize , thanks for the PR. In the ecosystem we consider vLLM as a Local App rather than a library. If you go onhttps://huggingface.co/mistralai/Mistral-Small-24B-Base-2501?local-app=vllm for instance, you'll see how to serve the model using vLLM. If you are interested in counting the downloads of model repos based onmistral-common, I would suggest to registermistral-common instead. PR would look like this:

#(toaddinalphabeticalorder)"mistral-common":{prettyLabel:"mistral-common",repoName:"mistral-common",repoUrl:"https://github.com/mistralai/mistral-common",docsUrl:"https://mistralai.github.io/mistral-common/",countDownloads:`path:"config.json" OR path:"params.json"`,},

(I haven't added a code snippet as I'm unsure how to use mistral common)

You'll also have to addlibrary_name: mistral-common in the model card metadata of your models.

Regarding the PR itself, we won't merge it in its current form. vLLM is a widely used app that is not specific to mistral-common (seehttps://huggingface.co/models?other=vllm) so we don't want the snippet to include mistral-specific instructions for all of them.

Btw, vllm snippets are definedhere. It is possible to update the install command to includepip install -U mistral-common for models withmistral-common tag (e.g.if model.tags.includes("mistral-common") ...)

Hi@Wauplin thanks a lot for your detailed feedback and given me the context and the pointers ! much appreciated.

so we don't want the snippet to include mistral-specific instructions for all of them.

This was indeed also a concern for me when I pushed the original PR, and also why I put Mistral related instruction in comments. So, very cool that your proposed solution avoids that.

I updated the PR accordingly.

I just have a question regarding how tags works, is the library_name considered as a tag ? meaning would that be True:

model.tags.includes("mistral-common")// = True ?

Or should I update the PR to check the library_name ?