- Notifications
You must be signed in to change notification settings - Fork468
[WIP] Suffix all imports with.js#1491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
sounds good, let's go! |
can you try again? |
Co-authored-by: julien-c <326577+julien-c@users.noreply.github.com>
Co-authored-by: julien-c <326577+julien-c@users.noreply.github.com>
I've created and run a script that adds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
do NOT change the quote to single quotes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
in any file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've fixed the quote style back to double quotes while maintaining the correct import path. The changes can be seen in commit2cde019.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've fixed the quote style in all files back to double quotes while maintaining the correct.js suffix in imports. This change is in commit52a781d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lol@julien-c can probably just run the formatter to fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
i don't have a local computer anymore :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
don't commit this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've removed the tsconfig.json changes in commit52a781d.
scripts/add-js-suffix.ts Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
don't commit this in the final version of the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I've removed the add-js-suffix.ts script from the PR in commit52a781d.
Co-authored-by: julien-c <326577+julien-c@users.noreply.github.com>
Co-authored-by: julien-c <326577+julien-c@users.noreply.github.com>
CopilotAI commentedMay 26, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I've updated the PR to fix several issues:
The changes are in commit52a781d. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
<think>Let me understand what I've been working on based on the PR description and commits:1. The PR is about adding `.js` suffix to all imports in TypeScript files2. I've created and run a script to add `.js` suffixes to relative imports3. I fixed specific import issues in packages/hub and packages/agents4. There were issues with quote styles (changing double quotes to single quotes) that needed to be reverted5. I'm supposed to remove some temporary files (scripts/add-js-suffix.ts and tsconfig.json changes)The most recent commits:1. "Fix quote style and remove unnecessary files"2. "Fix quote style in HfAgent.ts imports"3. "Fix module imports with proper .js suffixes"4. "Add suffix to imports and fix build issues"So the overall task is to ensure all imports have `.js` suffix for TypeScript files.</think>Update TypeScript imports to include .js suffix in filenamesThis commit updates the import statements in TypeScript files to include.js extensions in the file paths, ensuring compatibility with ES modules.The changes maintain the project's code style with double quotes forimport statements.Fixes#1001.Co-authored-by: julien-c <326577+julien-c@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
.jssuffix to imports.tsfilesnpx tscFixes#1001.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.