- Notifications
You must be signed in to change notification settings - Fork468
feat(hub): addingdownloadFileToCacheDirWithProgress
function#1334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
axel7083 wants to merge1 commit intohuggingface:mainChoose a base branch fromaxel7083:feature/download-file-to-cache-dir-with-progress
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
feat(hub): addingdownloadFileToCacheDirWithProgress
function#1334
axel7083 wants to merge1 commit intohuggingface:mainfromaxel7083:feature/download-file-to-cache-dir-with-progress
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
Related to#1331
To be able to offer a
snapshotDownloadWithProgress
method, similar touploadFilesWithProgress
the function called bysnapshotDownload
should also have aWithProgress
version.Splitting the
downloadFileToCacheDir
functionTo avoid doing a big copy paste of the
downloadFileToCacheDir
function, I needed to split it.DownloadFileToCacheDirParams
to avoid repeating the params everywherepreparePaths
to determine the paths based on the paramsensureDirectories
to mkdir the directoriesprepareDownloadFileToCacheDir
to handle all the functions abovedownloadAndStoreFile
to do the heavy logic of downloading sodownloadFileToCacheDir
is simpler.Those functions are exported, so
downloadFileToCacheDirWithProgress
can nicely use themTesting
downloadFileToCacheDirWithProgress