- Notifications
You must be signed in to change notification settings - Fork337
Update streamlit iframe to working hf space#1364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| Please note that we have added `?embed=true` to the URL, which activates the embed mode of the Streamlit app, removing some spacers and the footer for slim embeds. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
is this not relevant anymore? (im not sure)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not when when i updated the hf spaces in kornias docs as e.g. here (it is live):https://github.com/kornia/kornia/pull/2964/files#diff-bec16dbe99a3892599bb805746d7f3e56135fe05df0166f4fc2d86cf9ab22b5e
Also checked here:https://huggingface.co/docs/hub/spaces-embed#embedding-with-iframes where it also does not seem to be necessary.
Updated the streamlit iframe link to point to a working streamlit space.
Closes:#1363