- Notifications
You must be signed in to change notification settings - Fork6.1k
Fix kontext finetune issue when batch size >1#11921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Signed-off-by: mymusise <mymusise1@gmail.com>
cc:@linoytsaban |
sayakpaul approved these changesJul 15, 2025
HuggingFaceDocBuilderDev commentedJul 15, 2025
The docs for this PR livehere. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
linoytsaban approved these changesJul 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks! failing test is not related to this PR |
cde02b0 intohuggingface:main 24 of 25 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Problem
Training fails with shape mismatch when using custom instance prompts and
batch_size > 1due to partial batches from the dataloader.Solution
Set
drop_last=TrueinBucketBatchSamplerto ensure consistent batch sizes during training. This prevents shape mismatch errors when the last batch is smaller than the specified batch size.Testing
Verified the fix resolves the shape mismatch error by running training with custom instance prompts and
batch_size > 1. No shape mismatch occurs after this change.Fixes # (issue)
Before submitting
Who can review?
Anyone in the community is free to review the PR once the tests have passed.
For this example script and dataloader logic, relevant reviewers could be: