- Notifications
You must be signed in to change notification settings - Fork6.1k
Fix: Exclude module handling in LoRA weight loading#11911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
yeonjoon-jung01 wants to merge1 commit intohuggingface:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Fix: Exclude module handling in LoRA weight loading#11911
yeonjoon-jung01 wants to merge1 commit intohuggingface:mainfromyeonjoon-jung01:fix/lora_exclude_modules
+5 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
- Updated the logic in to use a set for exclude modules, improving efficiency and clarity. - Enhanced the filtering process to ensure only relevant modules are excluded based on the target modules set.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in src/diffusers/utils/peft_utils.py when loading LoRA weights: if an excluded module name is a substring of a target module name, it unintentionally prevents the target module from being loaded.
A simple reproduction example:
This is a known issue, as discussed in:
load_lora_weightsbug in FLUX.1diffusers-0.35.0.dev0#11885exclude_moduleswon't consider the modules names intarget_modules#11874Although the PEFT library is preparing a fix (seehuggingface/peft#2637 (comment)), it's uncertain when that change will be released as part of a stable version. In the meantime, this bug exists in the current main branch of Diffusers and needs to be addressed immediately.
The proposed fix modifies the logic in Diffusers to ensure that exclude_modules are not substring of any target module name, preventing incorrect exclusions. This change may be rolled back in the future once the PEFT-side fix is available and adopted, but until then, it ensures correct and stable behavior for users.