Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Translation into Russian - first PR#93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
artyomboyko wants to merge12 commits intohuggingface:main
base:main
Choose a base branch
Loading
fromartyomboyko:main

Conversation

artyomboyko
Copy link

@artyomboykoartyomboyko commentedMay 10, 2024
edited
Loading

This is the first PR translation of the cookbook into Russian.

Any native speaker from the HF team can do the review. An earlier review was done by@MKhalusova.

@review-notebook-appReview Notebook App
Copy link

Check out this pull request on ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered byReviewNB

@artyomboyko
Copy link
Author

#92

@artyomboyko
Copy link
Author

@merveenoyan@stevhliu Hello, have a good day)

A few questions:

  1. How do I get a review here?
  2. Earlier documentation was built on a "demo server" and you could see if everything was correct (likehere). Is there any way to do that now (To make sure I don't break anything with my PR)?

@artyomboyko
Copy link
Author

@stevhliu Hello Steven. Can you please tell me who can do a review?

@HuggingFaceDocBuilderDev

The docs for this PR livehere. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu
Copy link
Member

Hi, thanks for the translation!

  1. You can ping Merve or I for a review, but please be patient :)
  2. The preview is automatically generated when we approve and run the workflow.
  3. I would check theforums orDiscord to see if there is another contributor who can read Russian to review your translation.
artyomboyko reacted with thumbs up emoji

@artyomboyko
Copy link
Author

@stevhliu Greate Thanks. But i dont see Russian in docs PR preview:

image

And I dont undestand why?

@artyomboyko
Copy link
Author

@stevhliu I think I found the problem:

image

I have not added the language code to the documentation build files (YAML files).

stevhliu reacted with thumbs up emoji

@artyomboyko
Copy link
Author

@stevhliu How we can rebuild doc preview?

@artyomboyko
Copy link
Author

artyomboyko commentedMay 15, 2024
edited
Loading

@stevhliu@merveenoyan Hello. HuggingFaceDocBuilderDev still does not show RU in preview. I've made all the necessary edits, but it just doesn't seem to be rebuilding the documentation.

image

How do I initiate a rebuild of the preview? If of course I can do that.

@stevhliu
Copy link
Member

It should work now :)

artyomboyko reacted with hooray emoji

@artyomboyko
Copy link
Author

@stevhliu@merveenoyan Good day. Anyway, I haven't found anyone who could do a review for Russian. I made it myself - by myself. Can I run the documentation preview build again? I want to see how the edits I made will look like.

@artyomboyko
Copy link
Author

@stevhliu@merveenoyan Good evening. Checked out the previews. Looks and reads good. We can merge.

@artyomboyko
Copy link
Author

@stevhliu@merveenoyan

I can help with the review (my native language is Russian). For other languages I can help with formatting and other small things like that. But I have never done it before. But I think - I will learn, the main thing is to try).

@stevhliu
Copy link
Member

Thanks for your translation, we appreciate your effort and work! However, to ensure the Cookbook's quality, we really should have a review from someone else who can also read Russian just to ensure there are no typos and it translates well. Hope you understand! 🤗

merveenoyan reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@artyomboyko@HuggingFaceDocBuilderDev@stevhliu

[8]ページ先頭

©2009-2025 Movatter.jp