- Notifications
You must be signed in to change notification settings - Fork327
Adding Catala as new language in notebooks/translatedrag_zephyr_langchain#77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered byReviewNB |
@MKhalusova@davanstrien can you please take a look? or give me feedback, thanks! |
artyomboyko commentedMay 15, 2024
@JanLeyva Hello. In order to fully add language support, a couple more edits need to be made.  You can see how I did it for Russian.  |
@blademoon addedca as a language in |
artyomboyko commentedMay 16, 2024
@stevhliu Good day. Can you approve doc preview building? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
notebooks/ca/_toctree.yml Outdated
| sections: | ||
| - local: index | ||
| title: Open-Source AI Cookbook | ||
| - local: rag_zephyr_langchain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This wasn't aligned which caused the doc building to fail. I think it'd also be nice to translate the title of the recipe here to Catalan
| -local:rag_zephyr_langchain | |
| -local:rag_zephyr_langchain |
notebooks/ca/index.md Outdated
| @@ -0,0 +1,21 @@ | |||
| # Open-Source AI Cookbook | |||
| The Open-Source AI Cookbook is a collection of notebooks illustrating practical aspects of building AI | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I noticed some of this isn't translated to Catalan yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for checking!
I just fixed the problem with_toctree.yml sorry about that, as well as full translatedindex.md to catalan. I'll look for more collaborators there, really appreciated!
fixing PR caused by error in `_toctree.yml`
translated to català
HuggingFaceDocBuilderDev commentedMay 17, 2024
The docs for this PR livehere. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Uh oh!
There was an error while loading.Please reload this page.
What does this PR do?
This PR adds the folder
cato the notebooks directory. The purpose is to include translated notebooks in Catalan, as well as to translate therag_zephyr_langchainnotebook into this language. I have already translated Index.md inside the ca folder and made modifications to_toctree.yamlas well.This marks my first contribution, and I welcome any feedback!
Who can review?
Someone that can check I did the structure properly, no technical changes made just translated a notebook and added a language.
@adeenayakup@MKhalusova