Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixed Typos and Clarifying Concepts on Semantic Cache Notebook#75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Tuvshno wants to merge1 commit intohuggingface:main
base:main
Choose a base branch
Loading
fromTuvshno:pr/cache-notebook-changes

Conversation

Tuvshno
Copy link

Hello, first time contributor here!

What does this PR do?

I was working through this great notebook and noticed a typo along with some areas that I felt needed clarifying in the code. The changes were mostly comments and a typo.

I fixed the "thresold" to "threshold" typo inside thesemantic_cache class.

In thesemantic_cache class, I tried to reduce the ambiguity of the code by adding a few clarifying comments since the class was the central point of the notebook. These additions aim to assist first-time readers in understanding the FAISS implementation.

These changes include adding clarification on:

  • The definitions of theD andI arrays that were returned fromindex.search()
  • Meaning ofnprobe
  • Adding comments on the meaning of the If conditions

I didn't want to overcomplicate the explanations as the contribution guide says, but I did want to give context that I thought could help a reader out.

Who can review?

@MKhalusova I would appreciate the review!

@review-notebook-appReview Notebook App
Copy link

Check out this pull request on ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered byReviewNB

Copy link
Collaborator

@merveenoyanmerveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

very general comment, thanks a lot

" self.index.nprobe = 8\n",
" self.index.nprobe = 8 # Number of nearby cells to search\n",
"\n",
" # D - Array of Distances between the query vector and nearest neighbors\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

repetitive comments here breaks readability of the code sometimes, would be nice to instead have a docstring

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@merveenoyanmerveenoyanmerveenoyan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Tuvshno@merveenoyan

[8]ページ先頭

©2009-2025 Movatter.jp