Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Rough in discussion of extensibility#384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mnot merged 13 commits intomasterfrommnot-44
Jul 9, 2020
Merged

Rough in discussion of extensibility#384

mnot merged 13 commits intomasterfrommnot-44
Jul 9, 2020

Conversation

@mnot
Copy link
Member

For#44

Copy link
Member

@royfieldingroyfielding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I am pretty sure that "constant" is not the word you are looking for. Maybe use persists and persistent instead?

@mnotmnot requested a review fromroyfieldingJune 22, 2020 06:21
@mnotmnot marked this pull request as ready for reviewJune 22, 2020 06:22
mnotand others added2 commitsJuly 2, 2020 17:13
Co-authored-by: Roy T. Fielding <fielding@gbiv.com>
Co-authored-by: Roy T. Fielding <fielding@gbiv.com>
@mnotmnot requested a review fromroyfieldingJuly 2, 2020 07:13
Comment on lines +5085 to +5089
<t>
Because CONNECT changes the request/response nature of an HTTP connection,
specific HTTP versions might have different ways of mapping its semantics
into the protocol's wire format.
</t>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think you missed my second comment that this paragraph doesn't say anything useful. AIUI, CONNECT was recently extended to allow an origin server to process it, which wasn't about the wire format.

I would prefer that we update the first paragraph to be less specific to 1.1 and then reference the CONNECT extension as an example of an allowed semantic extension because the method had no applicability for an origin server before.

I am also fine with merging this now and fixing CONNECT later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

RFC 7231 already permits origin servers to process CONNECT.

An origin server that receives a CONNECT request for itself MAY respond with a 2xx (Successful) status code to indicate that a connection is established. However, most origin servers do not implement CONNECT.

But yes, that extension stretches the bounds of this description.

Copy link
Contributor

@reschkereschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We mention only a subset of extension points; what about content encodings, auth schemes, range units...?

@mnotmnot merged commitff88ac8 intomasterJul 9, 2020
@mnotmnot deleted the mnot-44 branchJuly 9, 2020 06:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@reschkereschkereschke left review comments

@royfieldingroyfieldingroyfielding approved these changes

+1 more reviewer

@MikeBishopMikeBishopMikeBishop left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mnot@reschke@royfielding@MikeBishop
[8]ページ先頭
©2009-2025 Movatter.jp