Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Define origin and authority for http and https URIs#266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
royfielding merged 34 commits intomasterfromfielding-02
Feb 12, 2020

Conversation

@royfielding
Copy link
Member

Fixes#237 and#194 with the hope of being useful forquicwg/base-drafts#253

I suspect that we also need to move "Initiating HTTP over TLS" down to the section on Routing, but that can be done separately.

Copy link
Contributor

@martinthomsonmartinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is pretty good. I kept having comments, then finding that the concern was addressed in the next paragraph or shortly after it. I like that this defines authority in terms of both requirements (what amounts to TLS) and by exemplar (TLS over TCP).

Suggestions mostly.

Copy link
Contributor

@MikeBishopMikeBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a good start. Thanks for the rewrite!

@royfielding
Copy link
MemberAuthor

This is now ready to merge, IMO. There is more work to do after merging, specifically taking the old RFC2818 description of initiating HTTP over TLS out and moving just the 1.1-specific bits to Messaging, but I don't want to do that in the same PR.

@martinthomson
Copy link
Contributor

I agree with Roy. This is big enough that merging and iterating is the right path.

Copy link
Member

@mnotmnot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good enough to merge and iterate upon.

Will need change notes, of course.

@royfieldingroyfielding merged commit742758a intomasterFeb 12, 2020
@royfieldingroyfielding deleted the fielding-02 branchFebruary 12, 2020 20:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@mnotmnotmnot approved these changes

@reschkereschkeAwaiting requested review from reschke

@MikeBishopMikeBishopAwaiting requested review from MikeBishop

+1 more reviewer

@martinthomsonmartinthomsonmartinthomson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implications of Establishing Authority

6 participants

@royfielding@martinthomson@mnot@MikeBishop@reschke
[8]ページ先頭
©2009-2025 Movatter.jp