- Notifications
You must be signed in to change notification settings - Fork62
Add a bunch more tests for annotation-xml#80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
#data | ||
<math><annotation-xml> </annotation-xml> | ||
#errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should expect some errors for these new tests, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, we should. But AFAIK the errors in general are frequently wrong and I felt like giving up when I did this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I found the errors that existed were very helpful when writing a parser, but I understand it's a pain to add and maintain them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@nolanw I just don't have anything off-hand that's up-to-date to generate them from, which is what makes it a real pain. (HTMLReader doesn't have any easy-to-run test binary, does it? That, say, takes input from either a file or stdin and dumps the test expectation format?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I kinda gave up on the errors once things mostly worked ok (surprise!). That's a good idea for a lil binary though, I'll tuck that under my hat and maybe one day the errors will rain down on us all.
OK, LGTM with the "x" change |
No description provided.