Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update tests for relaxed <select> parser#178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
josepharhar wants to merge9 commits intohtml5lib:master
base:master
Choose a base branch
Loading
fromjosepharhar:select

Conversation

josepharhar
Copy link

@josepharharjosepharhar commentedOct 11, 2024•
edited
Loading

This PR updates the tree-construction dat files for the HTML change which will allow additional tags within<select>:
whatwg/html#10557

ghishadow and PowerWebsite reacted with laugh emoji
This PR updates the tree-construction dat files for the HTML changewhich will allow additional tags within <select>:whatwg/html#10557
@josepharhar
Copy link
Author

I'm not sure what the best practice is for rebaselining errors, but for now I removed all errors from affected tests. There are probably errors in tests I didn't change which may need to be rebaselined as well.

@annevk
Copy link
Contributor

Will there be a separate PR for new tests?

@flavorjones
Copy link
Contributor

FWIW when CI workflows are enabled, Nokogiri (downstream) tests will fail. I've started working on a branch with the proposed changes fromwhatwg/html#10557

@josepharhar
Copy link
Author

Will there be a separate PR for new tests?

I added new test cases to webkit02 including:

@flavorjones
Copy link
Contributor

Nokogiri work-in-progress atsparklemotion/nokogiri#3317

flavorjones added a commit to sparklemotion/nokogiri that referenced this pull requestOct 16, 2024
flavorjones added a commit to flavorjones/html5lib-tests that referenced this pull requestOct 16, 2024
@flavorjones
Copy link
Contributor

@josepharhar I've got a question about two tests that are very similar. Zooming in on this one fromtree-construction/tests1.dat:

#data<select><b><option><select><option></b></select>#errors#document| <html>|   <head>|   <body>|     <select>|       <b>|         <option>|     <b>|     <select>|       <b>|         <option>

Nokogiri is constructing a different tree:

<body>  <select>    <b>      <option>  <b>    <select>      <option>

and I wanted to ask for a double-check that the test's assertion is correct, before I dive into Nokogiri's parser. Thank you!

@josepharhar
Copy link
Author

Thanks for asking!

It looks like Nokogiri is nesting one<select> inside the other, and my spec/chromium change intentionally fully closes the outer select before inserting the new one, so yeah I think the test's assertion is correct.

Here's the relevant part of the spec PR:https://whatpr.org/html/10557/parsing.html#:~:text=A%20start%20tag%20whose%20tag%20name%20is%20%22select%22

As for the<b> in between the<select> and the<option>, I think there is a mismatch between my spec PR and the chromium implementation - specificially the chromium implementations stops in this case before reconstructing formatting contexts, which isn't in the spec:https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/parser/html_tree_builder.cc;l=951;drc=9776ce6636ab1d68d2b1c4f1f719eb71becf39a3

I'll take a closer look at which we should do and get back to you on that. Thanks!

@flavorjones
Copy link
Contributor

flavorjones commentedOct 17, 2024•
edited
Loading

Thanks for replying so quickly.

It looks like Nokogiri is nesting oneselect inside the other

No, sorry, unless I'm misunderstanding your comment, this is not a correct description of what Nokogiri's parser is doing. Here's a more graphical representation of the tree from my previous comment:

body├── select│   └── b│       └── option└── b    └── select        └── option

i.e.<body><select><b><option></option></b></select><b><select><option></option></select></b></body>.

The select tags are not nested. Just wanted to clarify. (And if it's helpful context, Nokogiri is maintaining a fork of libgumbo.)

@josepharhar
Copy link
Author

Ah whoops, I failed to read the tree properly 😅

I looked into why chromium is putting the b inside the select instead of the other way around, and i found that the</b> tag in the test is what's making the difference - without it I am getting the same output as Nokogiri.

This is happening due to this call to the adoption agency algorithm when</b> is parsed:https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-inbody:adoption-agency-algorithm-4

I verified that chromium does the same thing as Nokogiri when I comment out that call to the adoption agency algorithm.

There's a lot of steps in that algorithm and I'm having a hard time wrapping my head around it, but does Nokogiri have that call to the adoption agency algorithm too? Or perhaps the implementations of the algorithm are different?

@flavorjones
Copy link
Contributor

@josepharhar Thanks again for your kind reply!

Yes, Nokogiri's libgumbo has implemented the adoption agency algorithm, and I have confirmed that in these tests we are invoking it. It's helpful to know this is likely the source of the behavior difference, so I'll focus my efforts on making sure it matches the current spec (though I'll note it passes every other test in this suite ... 🤷).

@flavorjones
Copy link
Contributor

flavorjones commentedOct 18, 2024•
edited
Loading

OK, I think I know what's going on here. I think Chromium has missed this change:

image

https://github.com/whatwg/html/pull/10557/files#diff-41cf6794ba4200b839c53531555f0f3998df4cbb01a4d5cb0b94e3ca5e23947dR124618

Ifselect is not in the list for default scope tags, then this adoption agency step:

If formattingElement is in thestack of open elements, but the element is notin scope, then this is aparse error; return.

will not trigger a parse-error-and-return, and the algorithm will continue. Butselectis in the list now, and so the formatting elementb isnot in scope.

If I remove theselect tag from the default scope tags in Nokogiri's libgumbo, then behavior matches the test (and presumably chromium).

Can you check to see if my hunch is right?

@josepharhar
Copy link
Author

Thanks so much for figuring this out! Yeah I totally missed that in the chromium implementation but I just added it and updated the tests here.

flavorjones reacted with thumbs up emoji

@flavorjones
Copy link
Contributor

@josepharhar That's great! Thank you!

I've got a patch to get the error messages to a point where libgumbo is passing, would you mind taking a look and potentially applying to this PR? (Renamed to.txt to get by the github attachment filter.)

select-test-errors.patch.txt

@josepharhar
Copy link
Author

Looks good, thanks! I applied it.

Sometimes I wonder why chromiumthrows away parse errors.

aarongable pushed a commit to chromium/chromium that referenced this pull requestOct 30, 2024
This change was included in the parser spec changes but I forgot to addit to the implementation. It was identified here:html5lib/html5lib-tests#178Change-Id: I13f7ba11dc2dda814e488829a05fe4ee7c670d52Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/5948083Commit-Queue: Joey Arhar <jarhar@chromium.org>Reviewed-by: David Baron <dbaron@chromium.org>Cr-Commit-Position: refs/heads/main@{#1375607}
untitaker added a commit to untitaker/html5ever that referenced this pull requestOct 30, 2024
Neither the proposal nor the test changes are merged yet. Also, thetests are still failing.html5lib/html5lib-tests#178whatwg/html#10557
@untitaker
Copy link
Contributor

untitaker commentedNov 1, 2024•
edited
Loading

the changes to#errors makewebkit02 highly inconsistent and break existing norms in e.g. parse5. See alsowhatwg/html#1339

untitaker added a commit to untitaker/parse5 that referenced this pull requestNov 1, 2024
html5lib/html5lib-tests#178The proposal isn't merged yet, and the error codes are off. The forkedhtml5lib-tests makes it more complicated. I recommend to ditch the forkof html5lib-tests and give up on standardizing errors.
Co-authored-by: Markus Unterwaditzer <markus-github@unterwaditzer.net>
flavorjones added a commit to sparklemotion/nokogiri that referenced this pull requestNov 23, 2024
flavorjones added a commit to sparklemotion/nokogiri that referenced this pull requestNov 23, 2024
flavorjones added a commit to sparklemotion/nokogiri that referenced this pull requestNov 25, 2024
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull requestDec 4, 2024
This patch makes the HTML parser convert nested <select> tags into</select> instead of </select><select> for backwards compatibility withthe old parser. This behavior will apply to any nested selects, such as<select><div><select>.This was recommended here:whatwg/html#10557 (comment)This will be tested here:html5lib/html5lib-tests#178 (comment)Change-Id: I7a39901582b96edc10deca8794b9ce117aa08229
aarongable pushed a commit to chromium/chromium that referenced this pull requestDec 4, 2024
This patch makes the HTML parser convert nested <select> tags into</select> instead of </select><select> for backwards compatibility withthe old parser. This behavior will apply to any nested selects, such as<select><div><select>.This was recommended here:whatwg/html#10557 (comment)This will be tested here:html5lib/html5lib-tests#178 (comment)Change-Id: I7a39901582b96edc10deca8794b9ce117aa08229Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/6040687Commit-Queue: Joey Arhar <jarhar@chromium.org>Reviewed-by: David Baron <dbaron@chromium.org>Cr-Commit-Position: refs/heads/main@{#1391787}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull requestDec 4, 2024
This patch makes the HTML parser convert nested <select> tags into</select> instead of </select><select> for backwards compatibility withthe old parser. This behavior will apply to any nested selects, such as<select><div><select>.This was recommended here:whatwg/html#10557 (comment)This will be tested here:html5lib/html5lib-tests#178 (comment)Change-Id: I7a39901582b96edc10deca8794b9ce117aa08229Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/6040687Commit-Queue: Joey Arhar <jarhar@chromium.org>Reviewed-by: David Baron <dbaron@chromium.org>Cr-Commit-Position: refs/heads/main@{#1391787}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull requestDec 4, 2024
This patch makes the HTML parser convert nested <select> tags into</select> instead of </select><select> for backwards compatibility withthe old parser. This behavior will apply to any nested selects, such as<select><div><select>.This was recommended here:whatwg/html#10557 (comment)This will be tested here:html5lib/html5lib-tests#178 (comment)Change-Id: I7a39901582b96edc10deca8794b9ce117aa08229Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/6040687Commit-Queue: Joey Arhar <jarhar@chromium.org>Reviewed-by: David Baron <dbaron@chromium.org>Cr-Commit-Position: refs/heads/main@{#1391787}
aarongable pushed a commit to chromium/chromium that referenced this pull requestDec 4, 2024
Context here:whatwg/html#10557 (comment)Tests will be added here:html5lib/html5lib-tests#178 (comment)Change-Id: I62cd28979abff3d5ea30b3502872f273a74bfde4Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/6042598Commit-Queue: Joey Arhar <jarhar@chromium.org>Reviewed-by: David Baron <dbaron@chromium.org>Cr-Commit-Position: refs/heads/main@{#1391836}
@josepharhar
Copy link
Author

I just updated this PR, which mostly involved reverting stuff. Should all be up to date and in sync with the whatwg/html PR now.

flavorjones reacted with heart emoji

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull requestDec 10, 2024
…t>, a=testonlyAutomatic update from web-platform-testsChange parser behavior of <select><select>This patch makes the HTML parser convert nested <select> tags into</select> instead of </select><select> for backwards compatibility withthe old parser. This behavior will apply to any nested selects, such as<select><div><select>.This was recommended here:whatwg/html#10557 (comment)This will be tested here:html5lib/html5lib-tests#178 (comment)Change-Id: I7a39901582b96edc10deca8794b9ce117aa08229Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/6040687Commit-Queue: Joey Arhar <jarhar@chromium.org>Reviewed-by: David Baron <dbaron@chromium.org>Cr-Commit-Position: refs/heads/main@{#1391787}--wpt-commits: c4c67222e7b0677f92f43280837db48473603f1ewpt-pr: 49525
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull requestDec 12, 2024
…t>, a=testonlyAutomatic update from web-platform-testsChange parser behavior of <select><select>This patch makes the HTML parser convert nested <select> tags into</select> instead of </select><select> for backwards compatibility withthe old parser. This behavior will apply to any nested selects, such as<select><div><select>.This was recommended here:whatwg/html#10557 (comment)This will be tested here:html5lib/html5lib-tests#178 (comment)Change-Id: I7a39901582b96edc10deca8794b9ce117aa08229Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/6040687Commit-Queue: Joey Arhar <jarhar@chromium.org>Reviewed-by: David Baron <dbaron@chromium.org>Cr-Commit-Position: refs/heads/main@{#1391787}--wpt-commits: c4c67222e7b0677f92f43280837db48473603f1ewpt-pr: 49525
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull requestDec 13, 2024
…t>, a=testonlyAutomatic update from web-platform-testsChange parser behavior of <select><select>This patch makes the HTML parser convert nested <select> tags into</select> instead of </select><select> for backwards compatibility withthe old parser. This behavior will apply to any nested selects, such as<select><div><select>.This was recommended here:whatwg/html#10557 (comment)This will be tested here:html5lib/html5lib-tests#178 (comment)Change-Id: I7a39901582b96edc10deca8794b9ce117aa08229Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/6040687Commit-Queue: Joey Arhar <jarharchromium.org>Reviewed-by: David Baron <dbaronchromium.org>Cr-Commit-Position: refs/heads/main{#1391787}--wpt-commits: c4c67222e7b0677f92f43280837db48473603f1ewpt-pr: 49525UltraBlame original commit: 666bbfe1252e12af9394a702ad62918ae14f44c2
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull requestDec 13, 2024
…t>, a=testonlyAutomatic update from web-platform-testsChange parser behavior of <select><select>This patch makes the HTML parser convert nested <select> tags into</select> instead of </select><select> for backwards compatibility withthe old parser. This behavior will apply to any nested selects, such as<select><div><select>.This was recommended here:whatwg/html#10557 (comment)This will be tested here:html5lib/html5lib-tests#178 (comment)Change-Id: I7a39901582b96edc10deca8794b9ce117aa08229Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/6040687Commit-Queue: Joey Arhar <jarharchromium.org>Reviewed-by: David Baron <dbaronchromium.org>Cr-Commit-Position: refs/heads/main{#1391787}--wpt-commits: c4c67222e7b0677f92f43280837db48473603f1ewpt-pr: 49525UltraBlame original commit: 666bbfe1252e12af9394a702ad62918ae14f44c2
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull requestDec 13, 2024
…t>, a=testonlyAutomatic update from web-platform-testsChange parser behavior of <select><select>This patch makes the HTML parser convert nested <select> tags into</select> instead of </select><select> for backwards compatibility withthe old parser. This behavior will apply to any nested selects, such as<select><div><select>.This was recommended here:whatwg/html#10557 (comment)This will be tested here:html5lib/html5lib-tests#178 (comment)Change-Id: I7a39901582b96edc10deca8794b9ce117aa08229Reviewed-on:https://chromium-review.googlesource.com/c/chromium/src/+/6040687Commit-Queue: Joey Arhar <jarharchromium.org>Reviewed-by: David Baron <dbaronchromium.org>Cr-Commit-Position: refs/heads/main{#1391787}--wpt-commits: c4c67222e7b0677f92f43280837db48473603f1ewpt-pr: 49525UltraBlame original commit: 666bbfe1252e12af9394a702ad62918ae14f44c2
@flavorjones
Copy link
Contributor

@josepharhar Twelve of the tests changed or added in the recent commits do not have the correct number of error messages in the test data.

I'm not sure if you wish to fix those up given the@untitaker feedback above, but if so here are the failures from the Nokogiri test suite. Please let me know if I can help format these for you.

nokogiri libgumbo error match failures
Finished in 1.434869s, 4618.5409 runs/s, 79923.6865 assertions/s.  1) Failure:TestHtml5TreeConstructionTests2#test_37__script_on [test/html5/test_tree_construction.rb:131]:Expected 2 errors for <!DOCTYPE html><select><optgroup><option></optgroup><option><select><option>, found:1:61: ERROR: Start tag 'select' isn't allowed here. Currently open tags: html, body, select, option.<!DOCTYPE html><select><optgroup><option></optgroup><option><select><option>                                                            ^.Expected: 2  Actual: 1  2) Failure:TestHtml5TreeConstructionTests2#test_37__script_off [test/html5/test_tree_construction.rb:131]:Expected 2 errors for <!DOCTYPE html><select><optgroup><option></optgroup><option><select><option>, found:1:61: ERROR: Start tag 'select' isn't allowed here. Currently open tags: html, body, select, option.<!DOCTYPE html><select><optgroup><option></optgroup><option><select><option>                                                            ^.Expected: 2  Actual: 1  3) Failure:TestHtml5TreeConstructionWebkit01#test_31__script_on [test/html5/test_tree_construction.rb:131]:Expected 9 errors for <select><option>A<select><option>B<select><option>C<select><option>D<select><option>E<select><option>F<select><option>G<select>, found:1:1: ERROR: Expected a doctype token<select><option>A<select><option>B<select><option>C<select><option>D<select><option>E<select><option>F<select><option>G<select>^1:18: ERROR: Start tag 'select' isn't allowed here. Currently open tags: html, body, select, option.<select><option>A<select><option>B<select><option>C<select><option>D<select><option>E<select><option>F<select><option>G<select>                 ^1:52: ERROR: Start tag 'select' isn't allowed here. Currently open tags: html, body, option, select, option.<select><option>A<select><option>B<select><option>C<select><option>D<select><option>E<select><option>F<select><option>G<select>                                                   ^1:86: ERROR: Start tag 'select' isn't allowed here. Currently open tags: html, body, option, select, option.<select><option>A<select><option>B<select><option>C<select><option>D<select><option>E<select><option>F<select><option>G<select>                                                                                     ^1:120: ERROR: Start tag 'select' isn't allowed here. Currently open tags: html, body, option, select, option.<select><option>A<select><option>B<select><option>C<select><option>D<select><option>E<select><option>F<select><option>G<select>                                                                                                                       ^.Expected: 9  Actual: 5  4) Failure:TestHtml5TreeConstructionWebkit01#test_31__script_off [test/html5/test_tree_construction.rb:131]:Expected 9 errors for <select><option>A<select><option>B<select><option>C<select><option>D<select><option>E<select><option>F<select><option>G<select>, found:1:1: ERROR: Expected a doctype token<select><option>A<select><option>B<select><option>C<select><option>D<select><option>E<select><option>F<select><option>G<select>^1:18: ERROR: Start tag 'select' isn't allowed here. Currently open tags: html, body, select, option.<select><option>A<select><option>B<select><option>C<select><option>D<select><option>E<select><option>F<select><option>G<select>                 ^1:52: ERROR: Start tag 'select' isn't allowed here. Currently open tags: html, body, option, select, option.<select><option>A<select><option>B<select><option>C<select><option>D<select><option>E<select><option>F<select><option>G<select>                                                   ^1:86: ERROR: Start tag 'select' isn't allowed here. Currently open tags: html, body, option, select, option.<select><option>A<select><option>B<select><option>C<select><option>D<select><option>E<select><option>F<select><option>G<select>                                                                                     ^1:120: ERROR: Start tag 'select' isn't allowed here. Currently open tags: html, body, option, select, option.<select><option>A<select><option>B<select><option>C<select><option>D<select><option>E<select><option>F<select><option>G<select>                                                                                                                       ^.Expected: 9  Actual: 5  5) Failure:TestHtml5TreeConstructionWebkit02#test_40__script_on [test/html5/test_tree_construction.rb:131]:Expected 4 errors for <select><button><select></select></button></select>, found:1:1: ERROR: Expected a doctype token<select><button><select></select></button></select>^1:17: ERROR: Start tag 'select' isn't allowed here. Currently open tags: html, body, select, button.<select><button><select></select></button></select>                ^1:25: ERROR: End tag 'select' isn't allowed here. Currently open tags: html, body.<select><button><select></select></button></select>                        ^1:34: ERROR: End tag 'button' isn't allowed here. Currently open tags: html, body.<select><button><select></select></button></select>                                 ^1:43: ERROR: End tag 'select' isn't allowed here. Currently open tags: html, body.<select><button><select></select></button></select>                                          ^.Expected: 4  Actual: 5  6) Failure:TestHtml5TreeConstructionWebkit02#test_38__script_off [test/html5/test_tree_construction.rb:131]:Expected 3 errors for <select><button>button</select>, found:1:1: ERROR: Expected a doctype token<select><button>button</select>^1:23: ERROR: End tag 'select' isn't allowed here. Currently open tags: html, body, select, button.<select><button>button</select>                      ^.Expected: 3  Actual: 2  7) Failure:TestHtml5TreeConstructionWebkit02#test_41__script_off [test/html5/test_tree_construction.rb:131]:Expected 2 errors for <select><button><div><select></select>, found:1:1: ERROR: Expected a doctype token<select><button><div><select></select>^1:22: ERROR: Start tag 'select' isn't allowed here. Currently open tags: html, body, select, button, div.<select><button><div><select></select>                     ^1:30: ERROR: End tag 'select' isn't allowed here. Currently open tags: html, body.<select><button><div><select></select>                             ^.Expected: 2  Actual: 3  8) Failure:TestHtml5TreeConstructionWebkit02#test_41__script_on [test/html5/test_tree_construction.rb:131]:Expected 2 errors for <select><button><div><select></select>, found:1:1: ERROR: Expected a doctype token<select><button><div><select></select>^1:22: ERROR: Start tag 'select' isn't allowed here. Currently open tags: html, body, select, button, div.<select><button><div><select></select>                     ^1:30: ERROR: End tag 'select' isn't allowed here. Currently open tags: html, body.<select><button><div><select></select>                             ^.Expected: 2  Actual: 3  9) Failure:TestHtml5TreeConstructionWebkit02#test_38__script_on [test/html5/test_tree_construction.rb:131]:Expected 3 errors for <select><button>button</select>, found:1:1: ERROR: Expected a doctype token<select><button>button</select>^1:23: ERROR: End tag 'select' isn't allowed here. Currently open tags: html, body, select, button.<select><button>button</select>                      ^.Expected: 3  Actual: 2 10) Failure:TestHtml5TreeConstructionWebkit02#test_40__script_off [test/html5/test_tree_construction.rb:131]:Expected 4 errors for <select><button><select></select></button></select>, found:1:1: ERROR: Expected a doctype token<select><button><select></select></button></select>^1:17: ERROR: Start tag 'select' isn't allowed here. Currently open tags: html, body, select, button.<select><button><select></select></button></select>                ^1:25: ERROR: End tag 'select' isn't allowed here. Currently open tags: html, body.<select><button><select></select></button></select>                        ^1:34: ERROR: End tag 'button' isn't allowed here. Currently open tags: html, body.<select><button><select></select></button></select>                                 ^1:43: ERROR: End tag 'select' isn't allowed here. Currently open tags: html, body.<select><button><select></select></button></select>                                          ^.Expected: 4  Actual: 5 11) Failure:TestHtml5TreeConstructionTests7#test_17__script_off [test/html5/test_tree_construction.rb:131]:Expected 2 errors for <!doctype html><select><select>X, found:1:24: ERROR: Start tag 'select' isn't allowed here. Currently open tags: html, body, select.<!doctype html><select><select>X                       ^.Expected: 2  Actual: 1 12) Failure:TestHtml5TreeConstructionTests7#test_17__script_on [test/html5/test_tree_construction.rb:131]:Expected 2 errors for <!doctype html><select><select>X, found:1:24: ERROR: Start tag 'select' isn't allowed here. Currently open tags: html, body, select.<!doctype html><select><select>X                       ^.Expected: 2  Actual: 1

flavorjones added a commit to sparklemotion/nokogiri that referenced this pull requestDec 19, 2024
@josepharhar
Copy link
Author

Please let me know if I can help format these for you.

That would be great! I could try but I might mess it up 😅

@flavorjones
Copy link
Contributor

flavorjones commentedJan 19, 2025•
edited
Loading

@josepharhar I've attached a patch file that indicates the number and nature of the error messages generated by libgumbo.

I want to acknowledge@untitaker's comment above that these error messages do not follow the format of other existing errors or the format suggested bywhatwg/html#1339, but this is the best I can do in the time I've allotted.

error_messages.patch.txt

@josepharhar
Copy link
Author

Thanks for generating those errors! I applied them in the latest commit

flavorjones reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@flavorjonesflavorjonesflavorjones left review comments

@zcorpanzcorpanzcorpan left review comments

@untitakeruntitakeruntitaker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@josepharhar@annevk@flavorjones@untitaker@zcorpan
[8]ページ先頭
©2009-2025 Movatter.jp