- Notifications
You must be signed in to change notification settings - Fork62
Move all CDATA section tests into one file#170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
not-my-profile wants to merge1 commit intohtml5lib:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
All other initial states are referenced outside the section 13.2.5Tokenization[1] that describes the tokenizer state machine.It's therefore reasonable to consider the 'CDATA section state'an implementation detail and as such a tokenizer may choose toavoid exposing it in it's public API.In that scenario while all other tests could be integration teststhat solely use the public API, the tests for the 'CDATA section state'would need to be performed internally rather than externally.This commit moves all the 'CDATA section state' tests into a newseparate cdataSection.test file to faciliate such testing.[1]:https://html.spec.whatwg.org/multipage/parsing.html#tokenization
To be clear, given that there's only a very high-level public API defined, most things are probably implementation details. Seems reasonable to move things around though. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All other initial states are referenced outside the section 13.2.5 Tokenization1 that describes the tokenizer state machine.
It's therefore reasonable to consider the 'CDATA section state' an implementation detail and as such a tokenizer may choose to avoid exposing it in it's public API.
In that scenario while all other tests could be integration tests that solely use the public API, the tests for the 'CDATA section state' would need to be performed internally rather than externally.
This commit moves all the 'CDATA section state' tests into a new separate cdataSection.test file to faciliate such testing.