Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix #11 by escaping enough to be safe in legacy browsers#95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@gsnedders
Copy link
Member

#11 given this isn't picked up from the title

@hoppipolla-critic-bot

Critic review:https://critic.hoppipolla.co.uk/r/227

This is an external review system which you may optionally use for the code review of your pull request.

@gsnedders
Copy link
MemberAuthor

The remaining failures are now-bogus tests in html5lib-tests (which expect spec behaviour by default, and not legacy-safe behaviour by default (which we want because of#12 — to be secure by default)).

@gsneddersgsnedders modified the milestones:0.9999,0.99999Apr 29, 2015
@gsneddersgsneddersforce-pushed theescape-characters-serializer branch fromb0eddff to791533eCompareMay 7, 2016 23:48
@gsneddersgsnedders modified the milestone:0.99999999May 8, 2016
@gsneddersgsneddersforce-pushed theescape-characters-serializer branch from791533e tod87ca9bCompareMay 9, 2016 15:20
@gsneddersgsneddersforce-pushed theescape-characters-serializer branch fromd87ca9b to6ddce87CompareMay 11, 2016 20:03
@codecov-io
Copy link

codecov-io commentedMay 11, 2016•
edited
Loading

Current coverage is89.37%

Merging#95 intomaster will increase coverage by+<.01%

@@             master        #95   diff @@==========================================  Files            50         50            Lines          6796       6809    +13     Methods           0          0            Messages          0          0            Branches       1318       1321     +3   ==========================================+ Hits           6071       6085    +14+ Misses          555        553     -2- Partials        170        171     +1
  1. File...ject_meta_charset.py (not in diff) was modified.more
    • Misses+1
    • Partials0
    • Hits-1

Powered byCodecov. Last updated byb48d0c1...8765511

@gsneddersgsneddersforce-pushed theescape-characters-serializer branch froma30eb28 to15ff801CompareMay 11, 2016 23:00
…legacy browsersThese are mostly out of the market now, so this isn't massivelyneeded any more; nevertheless, avoiding XSS as much as possible isinevitably desirable.This alters the API so that quote_attr_values is now a ternarysetting, choosing between legacy-safe behaviour, spec behaviour, andalways quoting.
@gsneddersgsneddersforce-pushed theescape-characters-serializer branch from8765511 to9b8d8ebCompareMay 11, 2016 23:55
@gsneddersgsnedders merged commitf6741ea intohtml5lib:masterMay 17, 2016
@gsneddersgsnedders deleted the escape-characters-serializer branchMay 17, 2016 22:08
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.99999999

Development

Successfully merging this pull request may close these issues.

3 participants

@gsnedders@hoppipolla-critic-bot@codecov-io
[8]ページ先頭
©2009-2025 Movatter.jp