- Notifications
You must be signed in to change notification settings - Fork303
setup.py: fix version parsing on Python 3.14 (ast.Str removed)#589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
atsampson commentedOct 8, 2025
This isn't right for pre-3.14 versions - the |
Python 3.14 removes the ast.Str node type. String literals now appearas ast.Constant(value=str).Update the AST check to accept both ast.Str (for older Pythons) andast.Constant with a string value (for Python 3.8+), allowing html5lib tobuild successfully on Python 3.14 while remaining compatible with olderversion.
sookach commentedOct 10, 2025
Thanks! Updated the PR. |
reneleonhardt commentedNov 26, 2025
Could you fix appveyor? For example the flake8 formatting. setup.py declares python_requires >= 2.7, but Python 3.13 is not tested in appveyor. Python 3.7 is EOL since 2023-06-27, when will it be allowed to not stay compatible anymore?
Python 2.7 is EOL since 2020-01-01, when will it be allowed to not stay compatible anymore?
|
Uh oh!
There was an error while loading.Please reload this page.
Python 3.14 removes the ast.Str node type. String literals now appear as ast.Constant(value=str).
Update the AST check to accept both ast.Str (for older Pythons) and ast.Constant with a string value (for Python 3.8+), allowing html5lib to build successfully on Python 3.14 while remaining compatible with older version. Tested at desk with
pip install -e .Fixes:#588