- Notifications
You must be signed in to change notification settings - Fork294
Don't use cElementTree on Python 3#502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-commenter commentedJun 10, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #502 +/- ##======================================= Coverage 91.06% 91.06% ======================================= Files 50 50 Lines 7036 7038 +2 Branches 1340 1341 +1 =======================================+ Hits 6407 6409 +2 Misses 475 475 Partials 154 154
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
r+ but I agree with the preference forif not PY2 in this case, although I'm obviously hoping Python 4 isn't a real thing since it will just cause more needless breakage.
It's been deprecated and will be removed in 3.9 or 3.10. 3.9.0b1 doesn'thave cElementTree. I'd like to bring it back with a deprecation warningto drop in 3.10.See:python/cpython#19921Signed-off-by: Christian Heimes <christian@python.org>Signed-off-by: Sam Sneddon <me@gsnedders.com>
Note that this has been discussed upstream at six on a number of occasions: seehttps://bitbucket.org/gutworth/six/issues/22/variable-sixpy3-is-time-bomb andbenjaminp/six#297, as well as the python-dev thread athttps://mail.python.org/archives/list/python-dev@python.org/thread/M5N3PZP4IUMKRZJKKJQA4IXK5VDX5MOP/ about 3.10 v. 4. |
I'm landing this as-is because if that's what a CPython core developer is doing that's good enough for me 🤷 |
This just directly imports the first commit frompypa/pip#8278.Fixes#494. This doesn't fill me with joy, but I guess sometimes we do the perhaps silly thing for pip.
(@tiran this is just your commit, let me know if you have any objection to it landing here)