Deprecate the sanitizer and recommend Bleach#501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gsnedders merged 3 commits intohtml5lib:masterfromgsnedders:deprecate-sanitizer

Jun 21, 2020

Merged

Deprecate the sanitizer and recommend Bleach#501

gsnedders merged 3 commits intohtml5lib:masterfromgsnedders:deprecate-sanitizer

Jun 21, 2020

Conversation

Copy link

Member

gsnedders commentedJun 10, 2020

See#443. cc/@jgraham @g-k

Deprecate the sanitizer and recommend Bleach

ba3fd73

Copy link

codecov-commenter commentedJun 10, 2020•
edited
Loading

Codecov Report

Merging#501 intomaster willincrease coverage by0.09%.
The diff coverage is100.00%.

@@            Coverage Diff             @@##           master     #501      +/-   ##==========================================+ Coverage   90.97%   91.07%   +0.09%==========================================  Files          49       50       +1       Lines        6936     7044     +108       Branches     1322     1341      +19     ==========================================+ Hits         6310     6415     +105- Misses        468      475       +7+ Partials      158      154       -4

Impacted Files	Coverage Δ
html5lib/filters/sanitizer.py	`93.38% <100.00%> (+0.22%)`	⬆️
html5lib/tests/sanitizer.py	`82.75% <100.00%> (+0.61%)`	⬆️
html5lib/tests/test_sanitizer.py	`94.80% <100.00%> (+0.06%)`	⬆️
html5lib/_utils.py	`82.95% <0.00%> (-4.55%)`	⬇️
html5lib/tests/support.py	`92.24% <0.00%> (-1.73%)`	⬇️
html5lib/html5parser.py	`98.43% <0.00%> (-0.02%)`	⬇️
html5lib/_inputstream.py	`91.77% <0.00%> (ø)`
html5lib/tests/test_parser2.py	`100.00% <0.00%> (ø)`
html5lib/tests/test_tokenizer2.py	`100.00% <0.00%> (ø)`
html5lib/_tokenizer.py	`99.59% <0.00%> (+<0.01%)`	⬆️
... and4 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updated49afd3...bbebb8d. Read thecomment docs.

jgraham reviewed

Jun 12, 2020

View reviewed changes

html5lib/filters/sanitizer.py

		@@ -11,6 +12,13 @@
		__all__ = ["Filter"]


		warnings.warn(
		"html5lib's sanitizer is deprecated; see " +

Copy link

Member

jgrahamJun 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Seems like this string could be a global.

g-k approved these changes

Jun 15, 2020

View reviewed changes

Copy link

g-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm

CHANGES.rst

		* Try to import from `collections.abc` to remove DeprecationWarning and ensure
		`html5lib` keeps working in future Python versions. (#403)
		* Drop optional `datrie` dependency. (#442)
		* Try to import from ``collections.abc`` to remove DeprecationWarning and ensure